Merge branch 'main' into sigp-audit-fixes

Author: jclapis

.github/workflows/release.yml

@@ -37,7 +37,6 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
         with:
-          ref: "stable"
           fetch-depth: 0
           submodules: true
 
@@ -108,7 +107,6 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
         with:
-          ref: "stable"
           fetch-depth: 0
           submodules: true
 
@@ -168,7 +166,6 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
         with:
-          ref: "stable"
           fetch-depth: 0
           submodules: true
 
@@ -221,7 +218,6 @@ jobs:
       - name: Checkout code
         uses: actions/checkout@v4
         with:
-          ref: "stable"
           fetch-depth: 0
           submodules: true
 

Cargo.lock

@@ -5,7 +5,7 @@ resolver = "2"
 [workspace.package]
 edition = "2024"
 rust-version = "1.89"
-version = "0.9.0"
+version = "0.9.2"
 
 [workspace.dependencies]
 aes = "0.8"
@@ -34,7 +34,7 @@ cb-metrics = { path = "crates/metrics" }
 cb-pbs = { path = "crates/pbs" }
 cb-signer = { path = "crates/signer" }
 cipher = "0.4"
-clap = { version = "4.5.4", features = ["derive", "env"] }
+clap = { version = "4.5.48", features = ["derive", "env"] }
 color-eyre = "0.6.3"
 const_format = "0.2.34"
 ctr = "0.9.2"

Cargo.toml

@@ -1,8 +1,20 @@
 use clap::Parser;
 
+/// Version string with a leading 'v'
+const VERSION: &str = concat!("v", env!("CARGO_PKG_VERSION"));
+
+/// Subcommands and global arguments for the module
+#[derive(Parser, Debug)]
+#[command(name = "Commit-Boost CLI", version = VERSION, about, long_about = None)]
+struct Cli {}
+
 /// Main entry point of the Commit-Boost CLI
 #[tokio::main]
 async fn main() -> eyre::Result<()> {
+    // Parse the CLI arguments (currently only used for version info, more can be
+    // added later)
+    let _cli = Cli::parse();
+
     color_eyre::install()?;
     // set default backtrace unless provided
 

bin/cli.rs

@@ -7,8 +7,20 @@ use clap::Parser;
 use eyre::Result;
 use tracing::{error, info};
 
+/// Version string with a leading 'v'
+const VERSION: &str = concat!("v", env!("CARGO_PKG_VERSION"));
+
+/// Subcommands and global arguments for the module
+#[derive(Parser, Debug)]
+#[command(name = "Commit-Boost PBS Service", version = VERSION, about, long_about = None)]
+struct Cli {}
+
 #[tokio::main]
 async fn main() -> Result<()> {
+    // Parse the CLI arguments (currently only used for version info, more can be
+    // added later)
+    let _cli = Cli::parse();
+
     color_eyre::install()?;
 
     let _guard = initialize_tracing_log(PBS_MODULE_NAME, LogsSettings::from_env_config()?);

bin/pbs.rs

@@ -7,8 +7,20 @@ use clap::Parser;
 use eyre::Result;
 use tracing::{error, info};
 
+/// Version string with a leading 'v'
+const VERSION: &str = concat!("v", env!("CARGO_PKG_VERSION"));
+
+/// Subcommands and global arguments for the module
+#[derive(Parser, Debug)]
+#[command(name = "Commit-Boost Signer Service", version = VERSION, about, long_about = None)]
+struct Cli {}
+
 #[tokio::main]
 async fn main() -> Result<()> {
+    // Parse the CLI arguments (currently only used for version info, more can be
+    // added later)
+    let _cli = Cli::parse();
+
     color_eyre::install()?;
 
     let _guard = initialize_tracing_log(SIGNER_MODULE_NAME, LogsSettings::from_env_config()?);

bin/signer.rs

@@ -89,6 +89,8 @@ headers = { X-MyCustomHeader = "MyCustomValue" }
 # OPTIONAL
 get_params = { param1 = "value1", param2 = "value2" }
 # Whether to enable timing games, as tuned by `target_first_request_ms` and `frequency_get_header_ms`.
+# NOTE: if neither `target_first_request_ms` nor `frequency_get_header_ms` is set, this flag has no effect.
+#
 # These values should be carefully chosen for each relay, as each relay has different latency and timing games setups.
 # They should only be used by advanced users, and if mis-configured can result in unforeseen effects, e.g. fetching a lower header value,
 # or getting a temporary IP ban.
@@ -150,7 +152,7 @@ validator_pubkeys = [
 # OPTIONAL
 loader = "./tests/data/mux_keys.example.json"
 # loader = { url = "http://localhost:8000/keys" }
-# loader = { registry = "lido", node_operator_id = 8, enable_refreshing = false }
+# loader = { registry = "lido", node_operator_id = 8, lido_module_id = 1, enable_refreshing = false }
 # loader = { registry = "ssv", node_operator_id = 8, enable_refreshing = false }
 late_in_slot_time_ms = 1500
 timeout_get_header_ms = 900
@@ -222,6 +224,9 @@ jwt_auth_fail_timeout_seconds = 300
 # Path to the CA certificate that signed the Dirk server certificate
 # OPTIONAL
 # ca_cert_path = "/path/to/ca.crt"
+# Limits the maximum size of a decoded gRPC response
+# OPTIONAL. Default: 4MB
+# max_response_size_bytes = 4194304
 
 # Add one entry like this for each Dirk host
 # [[signer.dirk.hosts]]

config.example.toml

@@ -27,6 +27,7 @@ ethereum_ssz_derive.workspace = true
 eyre.workspace = true
 futures.workspace = true
 jsonwebtoken.workspace = true
+lazy_static.workspace = true
 lh_eth2.workspace = true
 lh_eth2_keystore.workspace = true
 lh_types.workspace = true

crates/common/Cargo.toml

@@ -0,0 +1,37 @@
+[
+  {
+    "constant": true,
+    "inputs": [
+      { "name": "nodeOperatorId", "type": "uint256" }
+    ],
+    "name": "getNodeOperatorSummary",
+    "outputs": [
+      { "name": "targetLimitMode", "type": "uint256" },
+      { "name": "targetValidatorsCount", "type": "uint256" },
+      { "name": "stuckValidatorsCount", "type": "uint256" },
+      { "name": "refundedValidatorsCount", "type": "uint256" },
+      { "name": "stuckPenaltyEndTimestamp", "type": "uint256" },
+      { "name": "totalExitedValidators", "type": "uint256" },
+      { "name": "totalDepositedValidators", "type": "uint256" },
+      { "name": "depositableValidatorsCount", "type": "uint256" }
+    ],
+    "payable": false,
+    "stateMutability": "view",
+    "type": "function"
+  },
+  {
+    "constant": true,
+    "inputs": [
+      { "name": "nodeOperatorId", "type": "uint256" },
+      { "name": "startIndex", "type": "uint256" },
+      { "name": "keysCount", "type": "uint256" }
+    ],
+    "name": "getSigningKeys",
+    "outputs": [
+      { "name": "", "type": "bytes" }
+    ],
+    "payable": false,
+    "stateMutability": "view",
+    "type": "function"
+  }
+]