Rewrite get_header relay communication to support SSZ and JSON#467
Open
JasonVranek wants to merge 7 commits into
Open
Rewrite get_header relay communication to support SSZ and JSON#467JasonVranek wants to merge 7 commits into
JasonVranek wants to merge 7 commits into
Conversation
JasonVranek
force-pushed
the
pr/ssz-routes
branch
2 times, most recently
from
c800921 to
cbf451d
Compare
ninaiiad
reviewed
Jun 2, 2026
ninaiiad
reviewed
Jun 3, 2026
ninaiiad
approved these changes
Jun 4, 2026
ManuelBilbao
reviewed
Jun 9, 2026
| PbsClientError::NoPayload => StatusCode::BAD_GATEWAY, | ||
| PbsClientError::Internal => StatusCode::INTERNAL_SERVER_ERROR, | ||
| PbsClientError::DecodeError(_) => StatusCode::BAD_REQUEST, | ||
| PbsClientError::HeaderError(_) => StatusCode::BAD_REQUEST, |
Collaborator
There was a problem hiding this comment.
There's a test saying that it can return 406. I'd change either of them to match
commit-boost-client/crates/common/src/wire.rs
Lines 612 to 614 in a52b531
| // Create the Accept headers for requests | ||
| // Use the documented, deterministic preference: | ||
| // SSZ first (wire-efficient), JSON fallback. | ||
| send_headers.insert(ACCEPT, HeaderValue::from_static(OUTBOUND_ACCEPT)); |
Collaborator
There was a problem hiding this comment.
To make sure, in the description you mention that headers are forwarded to the relay but here we are hardcoding the accept. Is this behaviour expected?
Collaborator
There was a problem hiding this comment.
Furthermore, we have this function that seems to do the job, but it's never used anywhere
commit-boost-client/crates/common/src/wire.rs
Lines 300 to 304 in a52b531
Introduce EncodingType, AcceptedEncodings, and content negotiation primitives for SSZ support in the PBS pipeline. Includes: - EncodingType enum with FromStr/Display and MIME param tolerance - AcceptedEncodings with q-value aware Accept header parsing - SSZ bid value extraction from SignedBuilderBid by fork - deserialize_body and parse_response_encoding_and_fork helpers - Per-fork type aliases for BuilderBid and ExecutionPayloadHeader - SszValueError, PbsError::GeneralRequest, PbsClientError variants - Comprehensive unit tests for all new types and helpers - New deps: headers-accept, mediatype
content negotiation. Includes: - SSZ and JSON encoding/decoding for relay get_header responses - Content-Type and Eth-Consensus-Version header parsing - Accept header forwarding to relays with q-value ordering - MIME parameter tolerance on relay response Content-Type - Fork-aware SSZ bid value extraction for all supported forks - Mock relay and validator SSZ support in test infrastructure - get_header integration tests for both encodings - Dynamic port allocation in tests via get_free_listener
responses often carry text/plain; charset=utf-8 Content-Type, which failed parse_response_encoding_and_fork with "unsupported encoding type".
JasonVranek
force-pushed
the
pr/ssz-routes
branch
from
a52b531 to
2565c31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites get_header relay communication to support both SSZ and JSON content negotiation.
What's in this PR
get_free_listener(eliminates flaky CI from port collisions)Review notes
The route handler always takes the standard validation path in this PR. Configurable validation modes come in PR 4.
The test infrastructure changes (mock relay SSZ support, dynamic ports) are shared by both get_header and submit_block tests.
Part 2 of 4: SSZ types → get_header → submit_block → validation bypassing
Attribution
This work builds on the SSZ builder flow originally implemented by @eserilev
in #252 and ported to the current codebase by @jclapis in #403.
Co-authored-by: Eitan Seri-Levi eserilev@ucsc.edu
Co-authored-by: Joe Clapis jclapis@outlook.com