Adds a fluentcx picture#88
Merged
Merged
Conversation
JeremyJ78
requested review from
MarvinKlein1508,
PascalVorwerk and
oneolddev
as code owners
|
✅ All tests passed successfully Details on your Workflow / Core Tests page. |
Summary - Unit Tests Code CoverageSummary
CoverageFluentUI.Blazor.Community.Components - 75.2%
|
Contributor
|
Can you elabortae why you have added the <PackageVersion Include="Azure.Storage.Blobs" Version="12.25.0" />
<PackageVersion Include="Google.Cloud.Storage.V1" Version="4.13.0" />dependencies? |
Contributor
Author
|
My bad 😅 But I remove these two middleware plugins to reduce dependencies (and forgot to remove them from the csproj, I will remove them this evening) |
Contributor
Author
|
@MarvinKlein1508 : I've added for handling image url, azure, google and amazon cloud... Like this the user will have less work to do to resize image... The middleware allow the images to be resized, reducing quality and so on... |
Contributor
|
@JeremyJ78 do we need to provide these providers out of the box? I don't like having these dependencies in the library |
Contributor
Author
We can provide these providers out of the box (and avoid the users to create them) |
Contributor
|
@JeremyJ78 I would put them in a markdown file for easy copy and paste. |
Contributor
Author
Good Idea 😊 |
added 2 commits
October 13, 2025 17:19
create a markdown file to have the 3 images processing available as copy / paste
Contributor
Author
|
@MarvinKlein1508 : Done ! |
MarvinKlein1508
approved these changes
Oct 30, 2025
Contributor
|
Can you solve the conflicts? Will merge it then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Provides a FluentCxPicture, a component which can have multiple source of images and let the picture to choose which image to show on the screen (responsive images)
Provides a way to create shadow and many effects (grayscale, blur...)
Picture can have a caption and an overlay
✅ Checklist
General
Component-specific