Skip Docker check steps on Windows CI runners#1411
Merged
Conversation
The 'Verify Docker is running' and 'Dump docker info' steps are meaningless on Windows runners since Linux containers are not supported there. Gate both steps with runner.os == 'Linux' so they are skipped on Windows without affecting the Linux flow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.sh | bash -s -- 1411Or
iex "& { $(irm https://raw.githubusercontent.com/CommunityToolkit/Aspire/main/eng/scripts/dogfood-pr.ps1) } 1411" |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the integration test workflow to avoid running Linux-Docker diagnostics on Windows CI runners, where they’re not meaningful and may fail or mislead, while keeping the Linux behavior unchanged.
Changes:
- Gate the “Verify Docker is running” step to run only on Linux runners.
- Gate the “Dump docker info” diagnostic step to run only on Linux runners while preserving its
always()behavior on Linux.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/tests.yaml |
Adds runner.os == 'Linux' conditions to Docker verification/diagnostic steps so Windows jobs skip them. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 0
Contributor
Minimum allowed line rate is |
aaronpowell
temporarily deployed
to
azure-artifacts
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
The CI test matrix runs on both
ubuntu-latestandwindows-latest, but the "Verify Docker is running" and "Dump docker info" steps are meaningless on Windows runners because Linux containers are not supported there. Runningdocker infoon Windows would either fail or produce misleading output, and the diagnostic dump has no value.Both steps are now gated with
runner.os == 'Linux'so they are skipped on Windows runners entirely while the Linux flow is unchanged. The "Dump docker info" step preserves itsalways()behaviour on Linux (runs whether the job passed or failed).PR Checklist
Other information
N/A