Skip to content

Prevent race conditions in BindableProperty tests and benchmarks #3188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matt-goldman wants to merge 11 commits into from
Closed

Prevent race conditions in BindableProperty tests and benchmarks #3188

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
a9421df
Fix: [THREADSAFE] Use ThreadStatic for initializing property flag to …
matt-goldman Apr 6, 2026
3e78738
Use ThreadStatic for initialization flags in BindableProperty tests t…
matt-goldman Apr 6, 2026
93f1f36
Separate build and run steps in benchmarks to prevent parallel race c…
matt-goldman Apr 6, 2026
b75ccb6
Update OnValidationPropertyChanged to resolve race conditions
matt-goldman Apr 6, 2026
fd83e1d
Updsate LazyView LoadAsync test to allow indefinite wait for toekn ex…
matt-goldman Apr 6, 2026
127f834
Update src/CommunityToolkit.Maui/Behaviors/Validators/ValidationBehav…
matt-goldman Apr 6, 2026
50b3c4a
Merge branch 'main' into fix-threadsafe-bindable-property-generator
TheCodeTraveler Apr 8, 2026
8a54006
Make init flags instance fields, remove helper class prefix as now ne…
matt-goldman Apr 11, 2026
d34e922
Fix hard coded string value in test
matt-goldman Apr 11, 2026
7db8cd7
Merge branch 'main' into fix-threadsafe-bindable-property-generator
matt-goldman Apr 11, 2026
1dc38a8
Merge branch 'main' into fix-threadsafe-bindable-property-generator
matt-goldman Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,16 @@ jobs:
- name: Display dotnet info
run: dotnet --info

- name: Build Benchmarks
run: |
dotnet build ${{ env.PathToCommunityToolkitAnalyzersBenchmarksCsproj }} -c Release
dotnet build ${{ env.PathToCommunityToolkitSourceGeneratorsBenchmarksCsproj }} -c Release

- name: Run Analyzer Benchmarks
run: dotnet run --project ${{ env.PathToCommunityToolkitAnalyzersBenchmarksCsproj }} -c Release -- -a "${{ runner.temp }}"
run: dotnet run --project ${{ env.PathToCommunityToolkitAnalyzersBenchmarksCsproj }} -c Release --no-build -- -a "${{ runner.temp }}"

- name: Run Source Generator Benchmarks
run: dotnet run --project ${{ env.PathToCommunityToolkitSourceGeneratorsBenchmarksCsproj }} -c Release -- -a "${{ runner.temp }}"
run: dotnet run --project ${{ env.PathToCommunityToolkitSourceGeneratorsBenchmarksCsproj }} -c Release --no-build -- -a "${{ runner.temp }}"

- name: Publish Benchmarks
uses: actions/upload-artifact@v7
Expand Down
47 changes: 25 additions & 22 deletions ...ttributeSourceGeneratorTests/BindablePropertyAttributeSourceGenerator_CommonUsageTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -595,37 +595,40 @@ public partial class {{defaultTestClassName}} : View
namespace {{defaultTestNamespace}};
public partial class {{defaultTestClassName}}
{
[global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
bool __isInitializingText;
/// <summary>
/// BindableProperty for the <see cref = "Text"/> property.
/// </summary>
public static readonly global::Microsoft.Maui.Controls.BindableProperty TextProperty = global::Microsoft.Maui.Controls.BindableProperty.Create("Text", typeof(string), typeof({{defaultTestNamespace}}.{{defaultTestClassName}}), null, (Microsoft.Maui.Controls.BindingMode)0, null, null, null, null, __{{defaultTestClassName}}BindablePropertyInitHelpers.CreateDefaultText);
public partial string Text { get => __{{defaultTestClassName}}BindablePropertyInitHelpers.IsInitializingText ? field : (string)GetValue(TextProperty); set => SetValue(TextProperty, value); }
public static readonly global::Microsoft.Maui.Controls.BindableProperty TextProperty = global::Microsoft.Maui.Controls.BindableProperty.Create("Text", typeof(string), typeof({{defaultTestNamespace}}.{{defaultTestClassName}}), null, (Microsoft.Maui.Controls.BindingMode)0, null, null, null, null, __BindablePropertyInitHelpers.CreateDefaultText);
public partial string Text { get => __isInitializingText ? field : (string)GetValue(TextProperty); set => SetValue(TextProperty, value); }

[global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
bool __isInitializingCustomDuration;
/// <summary>
/// BindableProperty for the <see cref = "CustomDuration"/> property.
/// </summary>
public static readonly global::Microsoft.Maui.Controls.BindableProperty CustomDurationProperty = global::Microsoft.Maui.Controls.BindableProperty.Create("CustomDuration", typeof(System.TimeSpan), typeof({{defaultTestNamespace}}.{{defaultTestClassName}}), null, (Microsoft.Maui.Controls.BindingMode)0, null, null, null, null, __{{defaultTestClassName}}BindablePropertyInitHelpers.CreateDefaultCustomDuration);
public partial System.TimeSpan CustomDuration { get => __{{defaultTestClassName}}BindablePropertyInitHelpers.IsInitializingCustomDuration ? field : (System.TimeSpan)GetValue(CustomDurationProperty); set => SetValue(CustomDurationProperty, value); }
}
public static readonly global::Microsoft.Maui.Controls.BindableProperty CustomDurationProperty = global::Microsoft.Maui.Controls.BindableProperty.Create("CustomDuration", typeof(System.TimeSpan), typeof({{defaultTestNamespace}}.{{defaultTestClassName}}), null, (Microsoft.Maui.Controls.BindingMode)0, null, null, null, null, __BindablePropertyInitHelpers.CreateDefaultCustomDuration);
public partial System.TimeSpan CustomDuration { get => __isInitializingCustomDuration ? field : (System.TimeSpan)GetValue(CustomDurationProperty); set => SetValue(CustomDurationProperty, value); }

file static class __{{defaultTestClassName}}BindablePropertyInitHelpers
{
public static volatile bool IsInitializingText = false;
public static object CreateDefaultText(global::Microsoft.Maui.Controls.BindableObject bindable)
{
IsInitializingText = true;
var defaultValue = ((TestView)bindable).Text;
IsInitializingText = false;
return defaultValue;
}

public static volatile bool IsInitializingCustomDuration = false;
public static object CreateDefaultCustomDuration(global::Microsoft.Maui.Controls.BindableObject bindable)
[global::System.ComponentModel.EditorBrowsable(global::System.ComponentModel.EditorBrowsableState.Never)]
static class __BindablePropertyInitHelpers
{
IsInitializingCustomDuration = true;
var defaultValue = ((TestView)bindable).CustomDuration;
IsInitializingCustomDuration = false;
return defaultValue;
public static object CreateDefaultText(global::Microsoft.Maui.Controls.BindableObject bindable)
{
(({{defaultTestClassName}})bindable).__isInitializingText = true;
var defaultValue = (({{defaultTestClassName}})bindable).Text;
(({{defaultTestClassName}})bindable).__isInitializingText = false;
return defaultValue;
}

public static object CreateDefaultCustomDuration(global::Microsoft.Maui.Controls.BindableObject bindable)
{
(({{defaultTestClassName}})bindable).__isInitializingCustomDuration = true;
var defaultValue = (({{defaultTestClassName}})bindable).CustomDuration;
(({{defaultTestClassName}})bindable).__isInitializingCustomDuration = false;
return defaultValue;
}
}
}
""";
Expand Down
Loading
Loading