-
Notifications
You must be signed in to change notification settings - Fork 142
Remove ThemeListener? And/or refactor? #135
Copy link
Copy link
Open
Labels
components::helpersHelpers for Colors, Network, Camera, WeakEventListener, PackageVersion, ScreenUnit and more.Helpers for Colors, Network, Camera, WeakEventListener, PackageVersion, ScreenUnit and more.enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Metadata
Metadata
Assignees
Labels
components::helpersHelpers for Colors, Network, Camera, WeakEventListener, PackageVersion, ScreenUnit and more.Helpers for Colors, Network, Camera, WeakEventListener, PackageVersion, ScreenUnit and more.enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomers
Type
Projects
Status
📋 Backlog
ThemeListenerdoesn't work in the Windows App SDK at the moment, so thinking we should remove it for now until it's supported in the WASDK?In either case, we should refactor to remove the call to
EnqueueAsyncfor theDispatcherQueueExtensions so we don't need the Helper package to depend on the Extensions package. I think that's the only call there:Windows/components/Helpers/src/ThemeListener.cs
Lines 110 to 123 in be4577e
Seems to be the only use of the Extensions I believe in this project. (which also means the Collections package is pulling them in as they depend on the Helpers)