Skip to content

Commit 2f670ee

Browse files
authored
Merge pull request #1170 from CommunityToolkit/dev/reproducible-builds
Fix deterministic builds, improve GitHub links
2 parents 67c676c + 223fb36 commit 2f670ee

File tree

4 files changed

+4
-15
lines changed

4 files changed

+4
-15
lines changed

Directory.Build.props

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,17 +24,19 @@
2424
</Otherwise>
2525
</Choose>
2626

27+
<!-- Build-only packages for versioning and reproducible builds -->
2728
<ItemGroup>
2829
<PackageReference Include="Nerdbank.GitVersioning" Version="3.9.50" PrivateAssets="All" IsImplicitlyReferenced="true" />
30+
<PackageReference Include="DotNet.ReproducibleBuilds" Version="2.0.2" PrivateAssets="all" IsImplicitlyReferenced="true" />
2931
</ItemGroup>
3032

3133
<Choose>
3234
<When Condition="'$(SourceLinkEnabled)' != 'false'">
3335
<PropertyGroup>
34-
<!-- Declare that the Repository URL can be published to NuSpec -->
35-
<PublishRepositoryUrl>true</PublishRepositoryUrl>
36+
3637
<!-- Embed source files that are not tracked by the source control manager to the PDB -->
3738
<EmbedUntrackedSources>true</EmbedUntrackedSources>
39+
3840
<!-- Include PDB in the built .nupkg -->
3941
<AllowedOutputExtensionsInPackageBuildOutputFolder>$(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder>
4042
</PropertyGroup>

build/Community.Toolkit.Common.props

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@
4646
<PropertyGroup>
4747
<IsPackable>true</IsPackable>
4848
<IsPublishable>true</IsPublishable>
49-
<ContinuousIntegrationBuild>$(TF_BUILD)</ContinuousIntegrationBuild>
5049
</PropertyGroup>
5150

5251
</Project>

src/CommunityToolkit.Mvvm.CodeFixers/CommunityToolkit.Mvvm.CodeFixers.props

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,6 @@
44
<TargetFramework>netstandard2.0</TargetFramework>
55
<IsPackable>false</IsPackable>
66
<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
7-
8-
<!-- Embed the .pdb file (see notes in the MVVM Toolkit generator projects) -->
9-
<DebugType>embedded</DebugType>
107
</PropertyGroup>
118

129
<!-- Simplified version of the same props as the source generators -->

src/CommunityToolkit.Mvvm.SourceGenerators/CommunityToolkit.Mvvm.SourceGenerators.props

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,6 @@
44
<TargetFramework>netstandard2.0</TargetFramework>
55
<IsPackable>false</IsPackable>
66
<EnforceExtendedAnalyzerRules>true</EnforceExtendedAnalyzerRules>
7-
8-
<!--
9-
While this project does not produce a .dll that consuming projects execute at runtime, we still want to
10-
include debugging information, to make it easier to debug the generator themselves in case of issues.
11-
Rather than using portable .pdb files, we just embed them, to ensure debuggers will load them correctly.
12-
Using portable .pdb-s results in Visual Studio not automatically loading them when attaching a debugger
13-
to the Roslyn code analysis process to try to debug the generators, forcing to pick the path manually.
14-
-->
15-
<DebugType>embedded</DebugType>
167
</PropertyGroup>
178

189
<!--

0 commit comments

Comments
 (0)