Skip to content

Commit 7573a67

Browse files
test(tui): use Windows absolute system root fixtures (OpenCoven#98 OpenCoven#99 OpenCoven#104 OpenCoven#110)
Refs OpenCoven#98. Refs OpenCoven#99. Refs OpenCoven#104. Refs OpenCoven#110. - keep hosted identity/scoping tests portable on Windows - preserve Phase 2 full-suite test coverage Signed-off-by: Timothy Wayne Gregg <Timothy.Gregg@complete.tech>
1 parent a113913 commit 7573a67

2 files changed

Lines changed: 9 additions & 8 deletions

File tree

docs/shared/hosted-review-phase-2-pr.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@ Fixes #110.
1515
- Adds hosted-derived settings sync project keys and hosted team-memory repo keys so hosted callers do not pass arbitrary project ids.
1616
- Splits hosted memory domains for default branch, branch, release, pull request, and security-private review contexts.
1717
- Hardens Windows test isolation for home-derived paths and gates Unix-socket daemon tests to Unix.
18+
- Corrects Windows TUI system-root test fixtures to use drive-qualified absolute paths.
1819

1920
## Test evidence
2021

@@ -29,12 +30,12 @@ Fixes #110.
2930
- `cargo test -p claurst-core --lib roster_reset -- --nocapture`
3031
- `cargo test -p claurst-core --lib build_import_preview_maps_settings_and_doc -- --nocapture`
3132
- `cargo test -p claurst-core --lib test_imported_anthropic_cli_token_resolves_without_coven_oauth_client -- --nocapture`
33+
- `cargo test -p claurst-tui --lib windows_system_root --quiet`
34+
- `cargo test --workspace --quiet`
3235

3336
## Full-suite status
3437

35-
- `cargo test --workspace` progressed through CLI, ACP, API, bridge, buddy, commands, and core tests, then Smart App Control blocked an unsigned freshly built test binary.
36-
- Latest block: `C:\dev-cargo-target\coven-code\debug\deps\claurst_tools-f5b8d284b5de1d1b.exe`, OS error 4551.
37-
- Code Integrity event: Smart App Control reported the binary did not meet Enterprise signing level requirements under policy `{0283ac0f-fff1-49ae-ada1-8a933130cad6}`.
38+
- `cargo test --workspace --quiet` passes on Windows with `CARGO_TARGET_DIR=C:\dev-cargo-target\coven-code` after Smart App Control was disabled locally.
3839

3940
## Risk notes
4041

src-rust/crates/tui/src/app.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -7421,21 +7421,21 @@ role = "Research"
74217421
#[test]
74227422
fn windows_system_root_prefers_absolute_system_root() {
74237423
let root = windows_system_root_from_env(
7424-
Some(std::ffi::OsString::from("/windows")),
7425-
Some(std::ffi::OsString::from("/windir")),
7424+
Some(std::ffi::OsString::from(r"C:\Windows")),
7425+
Some(std::ffi::OsString::from(r"D:\WinDir")),
74267426
);
74277427

7428-
assert_eq!(root, std::ffi::OsString::from("/windows"));
7428+
assert_eq!(root, std::ffi::OsString::from(r"C:\Windows"));
74297429
}
74307430

74317431
#[test]
74327432
fn windows_system_root_falls_back_to_absolute_windir() {
74337433
let root = windows_system_root_from_env(
74347434
Some(std::ffi::OsString::from("relative-system-root")),
7435-
Some(std::ffi::OsString::from("/windir")),
7435+
Some(std::ffi::OsString::from(r"D:\WinDir")),
74367436
);
74377437

7438-
assert_eq!(root, std::ffi::OsString::from("/windir"));
7438+
assert_eq!(root, std::ffi::OsString::from(r"D:\WinDir"));
74397439
}
74407440

74417441
#[test]

0 commit comments

Comments
 (0)