Skip to content

Commit b34f371

Browse files
authored
Merge pull request #145 from ComplexData-MILA/binary_err
Binary err
2 parents efe0f5c + bac8d09 commit b34f371

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

app/repositories/implementations/analysis_repository.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,15 @@ async def create(self, analysis: Analysis) -> Analysis:
3434

3535
return self._to_domain(model)
3636

37+
async def update_stream_safe(self, analysis: Analysis) -> Analysis:
38+
"""Update with proper async handling."""
39+
db_obj = self._to_model(analysis)
40+
merged_obj = await self._session.merge(db_obj)
41+
await self._session.commit()
42+
self._session.expunge(merged_obj)
43+
44+
return analysis
45+
3746
async def get_with_relations(self, analysis_id: UUID) -> Optional[Analysis]:
3847
"""Get analysis with related sources and feedback."""
3948
query = (

app/services/analysis_orchestrator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -251,7 +251,7 @@ async def _generate_analysis(
251251
log_data = LogProbsData(tokens=analysis_text, probs=log_probs)
252252
current_analysis.log_probs = log_data
253253

254-
updated_analysis = await self._analysis_repo.update(current_analysis)
254+
updated_analysis = await self._analysis_repo.update_stream_safe(current_analysis)
255255

256256
yield {
257257
"type": "analysis_complete",

0 commit comments

Comments
 (0)