Skip to content

Commit a375443

Browse files
authored
Merge pull request #14531 from jan-cerny/ensure_redhat
Add ensure_redhat_gpgkey_installed to RHEL CIS
2 parents ca4cb43 + 4bd86ef commit a375443

16 files changed

Lines changed: 40 additions & 8 deletions

controls/cis_fedora.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -369,9 +369,14 @@ controls:
369369
levels:
370370
- l1_server
371371
- l1_workstation
372-
status: manual
373-
related_rules:
372+
status: partial
373+
rules:
374374
- ensure_fedora_gpgkey_installed
375+
notes: >
376+
In CIS Benchmark, the requirement is manual, because of GPG keys for 3rd party repositories.
377+
But, add the rule ensure_fedora_gpgkey_installed to the profile because the requirement 1.2.1.2
378+
adds ensure_gpgcheck_globally_activated which requires GPG key checking. If the Fedora
379+
GPG key wouldn't be installed, people won't be able to install any RPM package using dnf.
375380
376381
- id: 1.2.1.2
377382
title: Ensure gpgcheck is configured (Automated)

products/rhel10/controls/cis_rhel10.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -366,9 +366,14 @@ controls:
366366
levels:
367367
- l1_server
368368
- l1_workstation
369-
status: manual
370-
related_rules:
369+
status: partial
370+
rules:
371371
- ensure_redhat_gpgkey_installed
372+
notes: >
373+
In CIS Benchmark, the requirement is manual, because of GPG keys for 3rd party repositories.
374+
But, add the rule ensure_redhat_gpgkey_installed to the profile because the requirement 1.2.1.2
375+
adds ensure_gpgcheck_never_disabled which requires GPG key checking. If the Red Hat
376+
GPG key wouldn't be installed, people won't be able to install any RPM package using dnf.
372377
373378
- id: 1.2.1.2
374379
title: Ensure gpgcheck is configured (Automated)

products/rhel8/controls/cis_rhel8.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -379,9 +379,14 @@ controls:
379379
levels:
380380
- l1_server
381381
- l1_workstation
382-
status: manual
383-
related_rules:
382+
status: partial
383+
rules:
384384
- ensure_redhat_gpgkey_installed
385+
notes: >
386+
In CIS Benchmark, the requirement is manual, because of GPG keys for 3rd party repositories.
387+
But, add the rule ensure_redhat_gpgkey_installed to the profile because the requirement 1.2.1.2
388+
adds ensure_gpgcheck_never_disabled which requires GPG key checking. If the Red Hat
389+
GPG key wouldn't be installed, people won't be able to install any RPM package using dnf.
385390
386391
- id: 1.2.1.2
387392
title: Ensure gpgcheck is configured (Automated)

products/rhel9/controls/cis_rhel9.yml

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -361,9 +361,14 @@ controls:
361361
levels:
362362
- l1_server
363363
- l1_workstation
364-
status: manual
365-
related_rules:
364+
status: partial
365+
rules:
366366
- ensure_redhat_gpgkey_installed
367+
notes: >
368+
In CIS Benchmark, the requirement is manual, because of GPG keys for 3rd party repositories.
369+
But, add the rule ensure_redhat_gpgkey_installed to the profile because the requirement 1.2.1.2
370+
adds ensure_gpgcheck_never_disabled which requires GPG key checking. If the Red Hat
371+
GPG key wouldn't be installed, people won't be able to install any RPM package using dnf.
367372
368373
- id: 1.2.1.2
369374
title: Ensure gpgcheck is globally activated (Automated)

tests/data/profile_stability/rhel10/cis.profile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ disable_weak_deps
153153
ensure_gpgcheck_globally_activated
154154
ensure_journald_and_rsyslog_not_active_together
155155
ensure_pam_wheel_group_empty
156+
ensure_redhat_gpgkey_installed
156157
ensure_root_password_configured
157158
file_at_allow_exists
158159
file_at_deny_not_exist

tests/data/profile_stability/rhel10/cis_server_l1.profile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,7 @@ disable_users_coredumps
7474
ensure_gpgcheck_globally_activated
7575
ensure_journald_and_rsyslog_not_active_together
7676
ensure_pam_wheel_group_empty
77+
ensure_redhat_gpgkey_installed
7778
ensure_root_password_configured
7879
file_at_allow_exists
7980
file_at_deny_not_exist

tests/data/profile_stability/rhel10/cis_workstation_l1.profile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ disable_users_coredumps
7272
ensure_gpgcheck_globally_activated
7373
ensure_journald_and_rsyslog_not_active_together
7474
ensure_pam_wheel_group_empty
75+
ensure_redhat_gpgkey_installed
7576
ensure_root_password_configured
7677
file_at_allow_exists
7778
file_at_deny_not_exist

tests/data/profile_stability/rhel10/cis_workstation_l2.profile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -153,6 +153,7 @@ disable_weak_deps
153153
ensure_gpgcheck_globally_activated
154154
ensure_journald_and_rsyslog_not_active_together
155155
ensure_pam_wheel_group_empty
156+
ensure_redhat_gpgkey_installed
156157
ensure_root_password_configured
157158
file_at_allow_exists
158159
file_at_deny_not_exist

tests/data/profile_stability/rhel8/cis.profile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ enable_authselect
141141
ensure_gpgcheck_globally_activated
142142
ensure_gpgcheck_never_disabled
143143
ensure_pam_wheel_group_empty
144+
ensure_redhat_gpgkey_installed
144145
ensure_root_password_configured
145146
file_at_allow_exists
146147
file_at_deny_not_exist

tests/data/profile_stability/rhel8/cis_server_l1.profile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ enable_authselect
7272
ensure_gpgcheck_globally_activated
7373
ensure_gpgcheck_never_disabled
7474
ensure_pam_wheel_group_empty
75+
ensure_redhat_gpgkey_installed
7576
ensure_root_password_configured
7677
file_at_allow_exists
7778
file_at_deny_not_exist

0 commit comments

Comments
 (0)