Fix yamllint violations in automatus CI workflows#14744
Merged
Mab879 merged 2 commits intoMay 29, 2026
Conversation
Mab879
reviewed
May 28, 2026
marcusburghardt
added a commit
to marcusburghardt/content
that referenced
this pull request
May 29, 2026
Restore the original inline '# vX.Y.Z' comment style on all uses: lines to match the convention used across other workflow files. For notiz-dev/github-action-json-property lines that exceed 99 characters with inline comments, add yamllint disable-line directives instead of moving the comment to a separate line. Addresses PR ComplianceAsCode#14744 review feedback from @Mab879. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Mab879
approved these changes
May 29, 2026
Mab879
requested changes
May 29, 2026
Mab879
left a comment
Mab879
left a comment
Member
There was a problem hiding this comment.
Seems like this needs a rebase.
Fix all yamllint violations (26 per file) in the automatus-debian12 and automatus-ubuntu2204 GitHub Actions workflow files. Changes (formatting only, no functional changes): - Fix bracket spacing on branch filters - Break long apt-get/apt install commands with line continuations - Break long shell commands (git, python3, podman, wget, test scripts) using block scalars with line continuations - Move inline version comments from uses: lines to comment lines above to keep uses: references under 99 characters - Fold long if: expressions using >- YAML scalars - Fold long env values using >- YAML scalars - Rewrap long comments to fit within 99 characters - Shorten long step name text Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
Restore the original inline '# vX.Y.Z' comment style on all uses: lines to match the convention used across other workflow files. For notiz-dev/github-action-json-property lines that exceed 99 characters with inline comments, add yamllint disable-line directives instead of moving the comment to a separate line. Addresses PR ComplianceAsCode#14744 review feedback from @Mab879. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
marcusburghardt
force-pushed
the
fix-automatus-yamllint
branch
from
32889e6 to
faf30c9
Compare
Member
Author
Just rebased @Mab879 . Thanks for the review. :) |
|
@marcusburghardt: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Mab879
approved these changes
May 29, 2026
Arden97
pushed a commit
to Arden97/content
that referenced
this pull request
Jun 1, 2026
Restore the original inline '# vX.Y.Z' comment style on all uses: lines to match the convention used across other workflow files. For notiz-dev/github-action-json-property lines that exceed 99 characters with inline comments, add yamllint disable-line directives instead of moving the comment to a separate line. Addresses PR ComplianceAsCode#14744 review feedback from @Mab879. Assisted-by: OpenCode (claude-opus-4-6) Signed-off-by: Marcus Burghardt <maburgha@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
automatus-debian12.yamlandautomatus-ubuntu2204.yamlGitHub Actions workflow files.[ master, ...]to[master, ...])apt-get/aptinstall commands usingrun: |with\line continuationsgit,python3,podman,wget, test scripts) into multiline blocksuses:lines to comment lines above (e.g.,# notiz-dev/github-action-json-property v0.2.0)if:expressions using>-YAML scalarsenv:values using>-YAML scalarsRationale:
ci_lint.yml) only validates files modified by a PR. Any PR that touches either of these workflow files would trigger yamllint failures unrelated to the PR's changes.Review Hints:
yamllint -s -c .yamllint .github/workflows/automatus-debian12.yaml .github/workflows/automatus-ubuntu2204.yamldebian12vsubuntu2204). Reviewing one file thoroughly and then spot-checking the other for product name differences is sufficient.