Skip to content

CMP-4479: Fix manual remediation script discovery for rules with dashes/underscores #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vickeybrown wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −5
Open

CMP-4479: Fix manual remediation script discovery for rules with dashes/underscores #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions helpers/utilities.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1115,11 +1115,16 @@ func getRuleNameFromResultName(

func convertRuleNameToRegex(ruleName string) string {
// Escape any special regex characters in the rule name
escaped := regexp.QuoteMeta(ruleName)
// Replace literal \- and \_ with a character class that matches both - and _
pattern := strings.ReplaceAll(escaped, `\-`, `[-_]`)
pattern = strings.ReplaceAll(pattern, `\_`, `[-_]`)
return pattern
pattern := ""
for _, char := range ruleName {
if char == '-' || char == '_' {
pattern += `[-_]`
} else {
// Escape this individual character if it's a regex metacharacter
pattern += regexp.QuoteMeta(string(char))
}
}
return pattern
}

func findRulePath(tc *testConfig.TestConfig, rulePattern string) (rulePath string, found bool) {
Expand Down