refactor: Fix inherited stroke path fill fallback

Author: t-regbs

components/parser/kmp/svg/src/commonMain/kotlin/io/github/composegears/valkyrie/parser/kmp/svg/SVGParser.kt

@@ -68,11 +68,10 @@ object SVGParser {
     context(paintContext: PaintContext)
     private fun SVG.Path.toVectorPath(): IrVectorNode.IrPath {
         val resolvedFill = fill ?: paintContext.fill
-        val resolvedStrokeColor = strokeColor ?: paintContext.strokeColor
         var fillColor: IrColor? = resolvedFill?.let(SvgColorParser::parse)
         // NOTE: Only when fill and strokeColor is null use black FillColor as default color as
         //       fill can be none resulting to null.
-        fillColor = if (resolvedFill == null && resolvedStrokeColor == null) Black else fillColor
+        fillColor = if (resolvedFill == null && strokeColor == null) Black else fillColor
         val stroke = getSVGStrokeWithDefaults()
         return IrVectorNode.IrPath(
             name = id.orEmpty(),

components/parser/kmp/svg/src/commonTest/kotlin/io/github/composegears/valkyrie/parser/kmp/svg/SVGParserTest.kt

@@ -99,6 +99,34 @@ internal class SVGParserTest {
         )
     }
 
+    @Test
+    fun parse_path_with_inherited_root_stroke_defaults_to_black_fill() {
+        val svg = svg(fill = null, stroke = "#ff0000") {
+            """<path d="M4 4h16"/>"""
+        }
+
+        assertEquals(
+            actual = SVGParser.parse(svg).nodes,
+            expected = listOf(
+                IrVectorNode.IrPath(
+                    pathFillType = IrPathFillType.NonZero,
+                    fill = IrFill.Color(IrColor(0xFF000000)),
+                    paths = listOf(
+                        IrPathNode.MoveTo(4f, 4f),
+                        IrPathNode.RelativeHorizontalTo(16f),
+                    ),
+                    fillAlpha = 1f,
+                    stroke = IrStroke.Color(IrColor(0xFFFF0000)),
+                    strokeAlpha = 1f,
+                    strokeLineWidth = 0f,
+                    strokeLineCap = IrStrokeLineCap.Butt,
+                    strokeLineJoin = IrStrokeLineJoin.Miter,
+                    strokeLineMiter = 4f,
+                ),
+            ),
+        )
+    }
+
     @Test
     fun parse_path_with_inherited_group_fill() {
         val svg = svg(fill = "none") {

components/parser/kmp/svg/src/commonTest/kotlin/io/github/composegears/valkyrie/parser/kmp/svg/Utils.kt

@@ -4,7 +4,7 @@ internal fun testSVG(
     height: String = "24px",
     viewBox: String = "0 0 24 24",
     width: String = "24px",
-    fill: String = "#000000",
+    fill: String? = "#000000",
     children: List<SVG.Child>,
 ) = SVG(
     width = width,
@@ -18,7 +18,7 @@ internal inline fun svg(
     width: String = "24px",
     height: String = "24px",
     viewBox: String? = "0 0 24 24",
-    fill: String = "#000000",
+    fill: String? = "#000000",
     stroke: String? = null,
     strokeWidth: String? = null,
     strokeLineCap: String? = null,
@@ -35,7 +35,11 @@ internal inline fun svg(
         if (strokeWidth != null) appendLine("""stroke-width="$strokeWidth"""")
         if (strokeLineCap != null) appendLine("""stroke-linecap="$strokeLineCap"""")
         if (strokeLineJoin != null) appendLine("""stroke-linejoin="$strokeLineJoin"""")
-        appendLine("""fill="$fill">""")
+        if (fill != null) {
+            appendLine("""fill="$fill">""")
+        } else {
+            appendLine(">")
+        }
         appendLine(block())
         appendLine("</svg>")
     }