Skip to content

Commit d90b5b9

Browse files
committed
update changelog and improve size label localization
1 parent b8e1191 commit d90b5b9

5 files changed

Lines changed: 5 additions & 12 deletions

File tree

sdk/compose/icons/api/icons.api

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,6 @@ public final class io/github/composegears/valkyrie/sdk/compose/icons/colored/Boo
1717
public static final fun getBootstrapLogo (Lio/github/composegears/valkyrie/sdk/compose/icons/ValkyrieIcons$Colored;)Landroidx/compose/ui/graphics/vector/ImageVector;
1818
}
1919

20-
public final class io/github/composegears/valkyrie/sdk/compose/icons/colored/FontAwesomeLogoKt {
21-
public static final fun getFontAwesomeLogo (Lio/github/composegears/valkyrie/sdk/compose/icons/ValkyrieIcons$Colored;)Landroidx/compose/ui/graphics/vector/ImageVector;
22-
}
23-
2420
public final class io/github/composegears/valkyrie/sdk/compose/icons/colored/GoogleMaterialLogoKt {
2521
public static final fun getGoogleMaterialLogo (Lio/github/composegears/valkyrie/sdk/compose/icons/ValkyrieIcons$Colored;)Landroidx/compose/ui/graphics/vector/ImageVector;
2622
}

sdk/compose/icons/api/icons.klib.api

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ final object io.github.composegears.valkyrie.sdk.compose.icons/ValkyrieIcons { /
1414

1515
final val io.github.composegears.valkyrie.sdk.compose.icons.colored/BootstrapLogo // io.github.composegears.valkyrie.sdk.compose.icons.colored/BootstrapLogo|@io.github.composegears.valkyrie.sdk.compose.icons.ValkyrieIcons.Colored{}BootstrapLogo[0]
1616
final fun (io.github.composegears.valkyrie.sdk.compose.icons/ValkyrieIcons.Colored).<get-BootstrapLogo>(): androidx.compose.ui.graphics.vector/ImageVector // io.github.composegears.valkyrie.sdk.compose.icons.colored/BootstrapLogo.<get-BootstrapLogo>|<get-BootstrapLogo>@io.github.composegears.valkyrie.sdk.compose.icons.ValkyrieIcons.Colored(){}[0]
17-
final val io.github.composegears.valkyrie.sdk.compose.icons.colored/FontAwesomeLogo // io.github.composegears.valkyrie.sdk.compose.icons.colored/FontAwesomeLogo|@io.github.composegears.valkyrie.sdk.compose.icons.ValkyrieIcons.Colored{}FontAwesomeLogo[0]
18-
final fun (io.github.composegears.valkyrie.sdk.compose.icons/ValkyrieIcons.Colored).<get-FontAwesomeLogo>(): androidx.compose.ui.graphics.vector/ImageVector // io.github.composegears.valkyrie.sdk.compose.icons.colored/FontAwesomeLogo.<get-FontAwesomeLogo>|<get-FontAwesomeLogo>@io.github.composegears.valkyrie.sdk.compose.icons.ValkyrieIcons.Colored(){}[0]
1917
final val io.github.composegears.valkyrie.sdk.compose.icons.colored/GoogleMaterialLogo // io.github.composegears.valkyrie.sdk.compose.icons.colored/GoogleMaterialLogo|@io.github.composegears.valkyrie.sdk.compose.icons.ValkyrieIcons.Colored{}GoogleMaterialLogo[0]
2018
final fun (io.github.composegears.valkyrie.sdk.compose.icons/ValkyrieIcons.Colored).<get-GoogleMaterialLogo>(): androidx.compose.ui.graphics.vector/ImageVector // io.github.composegears.valkyrie.sdk.compose.icons.colored/GoogleMaterialLogo.<get-GoogleMaterialLogo>|<get-GoogleMaterialLogo>@io.github.composegears.valkyrie.sdk.compose.icons.ValkyrieIcons.Colored(){}[0]
2119
final val io.github.composegears.valkyrie.sdk.compose.icons.colored/LucideLogo // io.github.composegears.valkyrie.sdk.compose.icons.colored/LucideLogo|@io.github.composegears.valkyrie.sdk.compose.icons.ValkyrieIcons.Colored{}LucideLogo[0]

tools/idea-plugin/CHANGELOG.md

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
- Add validation for exact duplicate icon names (e.g., `test-icon.svg` and `test_icon.svg` both produce `TestIcon.kt`)
99
- Add validation for case-insensitive duplicate icon names to prevent file overwrites on macOS/Windows
1010
- Add automatic re-validation when `useFlatPackage` setting changes to detect new conflicts immediately
11-
- [Web Import] Add `Bootstrap` icons
11+
- [Web Import] Add `Bootstrap` icons provider
1212

1313
### Fixed
1414

@@ -36,7 +36,6 @@
3636

3737
- Add option to generate ImageVector paths using pathData strings
3838
- Support pathData strings in addPath/clipPathData in Preview
39-
- Add `Bootstrap` icon provider into Web import feature
4039

4140
### Removed
4241

tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/common/ui/IconSizeCustomization.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ import org.jetbrains.jewel.ui.component.styling.LocalGroupHeaderStyle
3838
* @param settings Current size settings
3939
* @param onSettingsChange Callback when settings change
4040
* @param onClose Callback when close is clicked
41-
* @param sizeLabel String resource key for size label
41+
* @param sizeLabel The label text displayed next to the current size value
4242
* @param modifier Modifier for the panel
4343
*/
4444
@Composable
@@ -67,7 +67,7 @@ fun IconSizeCustomization(
6767
verticalArrangement = Arrangement.spacedBy(8.dp),
6868
) {
6969
CenterVerticalRow(modifier = Modifier.padding(horizontal = 4.dp)) {
70-
Text(text = stringResource(sizeLabel))
70+
Text(text = sizeLabel)
7171
WeightSpacer()
7272
InfoText(text = stringResource("web.import.font.customize.px.suffix", size.roundToInt()))
7373
}
@@ -96,7 +96,7 @@ private fun IconSizeCustomizationPreview() = PreviewTheme(alignment = Alignment.
9696
.clip(RoundedCornerShape(topStart = 12.dp, bottomStart = 12.dp))
9797
.background(JewelTheme.globalColors.borders.normal),
9898
settings = settings,
99-
sizeLabel = "web.import.font.customize.size",
99+
sizeLabel = stringResource("web.import.font.customize.size"),
100100
onClose = {},
101101
onSettingsChange = { settings = it },
102102
)

tools/idea-plugin/src/main/kotlin/io/github/composegears/valkyrie/ui/screen/webimport/standard/StandardImportScreenUI.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -265,7 +265,7 @@ private fun IconsContent(
265265
settings = state.settings,
266266
onSettingsChange = onSettingsChange,
267267
onClose = { isSidePanelOpen = false },
268-
sizeLabel = "web.import.font.customize.size",
268+
sizeLabel = stringResource("web.import.font.customize.size"),
269269
)
270270
},
271271
)

0 commit comments

Comments
 (0)