Workaround for C++20 bug in nlohmann/json

nlohmann/json#3907

Author: franzpoeschel

include/picongpu/CMakeLists.txt

@@ -585,20 +585,25 @@ if(PIC_HAVE_openPMD)
         $<TARGET_PROPERTY:toml11::toml11,INTERFACE_INCLUDE_DIRECTORIES>)
     target_link_libraries(picongpu-hostonly PRIVATE toml11::toml11)
 
+endif()
+
+foreach(target picongpu picongpu-hostonly)
     # This is a workaround for a missing API call in the openPMD-api,
     # which currently does not re-export backend version information.
     # https://github.com/openPMD/openPMD-api/issues/1563
-    if(openPMD_HAVE_ADIOS2)
-        foreach(target picongpu picongpu-hostonly)
-            target_compile_definitions(
-                ${target}
-                PRIVATE
-                ADIOS2_VERSION_MAJOR=${ADIOS2_VERSION_MAJOR}
-                ADIOS2_VERSION_MINOR=${ADIOS2_VERSION_MINOR}
-                ADIOS2_VERSION_PATCH=${ADIOS2_VERSION_PATCH})
-        endforeach()
+    if(PIC_HAVE_openPMD AND openPMD_HAVE_ADIOS2)
+        target_compile_definitions(
+            ${target}
+            PRIVATE
+            ADIOS2_VERSION_MAJOR=${ADIOS2_VERSION_MAJOR}
+            ADIOS2_VERSION_MINOR=${ADIOS2_VERSION_MINOR}
+            ADIOS2_VERSION_PATCH=${ADIOS2_VERSION_PATCH})
     endif()
-endif()
+
+    # Workaround for this bug https://github.com/nlohmann/json/issues/3907
+    # We don't need ranges in <nlohmann/json.hpp>
+    target_compile_definitions(${target} PRIVATE JSON_HAS_RANGES=0)
+endforeach()
 
 ## annotate with RPATH's
 if(PIC_ADD_RPATH)

share/picongpu/unit/CMakeLists.txt

@@ -112,6 +112,10 @@ add_library(argparser
 target_link_libraries(argparser PRIVATE ${HOST_LIBS})
 target_link_libraries(argparser PRIVATE pmacc::pmacc)
 
+# Workaround for this bug https://github.com/nlohmann/json/issues/3907
+# We don't need ranges in <nlohmann/json.hpp>
+target_compile_definitions(argparser PRIVATE JSON_HAS_RANGES=0)
+
 # Add subdirectories for tests
 add_subdirectory(dimensional_tests)
 add_subdirectory(non_dimensional_tests)

share/picongpu/unit/dimensional_tests/CMakeLists.txt

@@ -6,6 +6,9 @@ foreach(dim 2 3)
         string(REPLACE "UT.cpp" "" testCase ${testCaseFilename})
         set(testExe "${PROJECT_NAME}-${testCase}-${dim}D")
         alpaka_add_executable(${testExe} ${testCaseFilepath})
+        # Workaround for this bug https://github.com/nlohmann/json/issues/3907
+        # We don't need ranges in <nlohmann/json.hpp>
+        target_compile_definitions(${testExe} PRIVATE JSON_HAS_RANGES=0)
         target_compile_definitions(${testExe} PRIVATE TEST_DIM=${dim})
         target_link_libraries(${testExe} PUBLIC Catch2 Catch2WithMain)
         target_link_libraries(${testExe} PRIVATE pmacc::pmacc)

share/picongpu/unit/non_dimensional_tests/CMakeLists.txt

@@ -5,6 +5,9 @@ foreach(testCaseFilepath ${NON_DIMENSIONAL_TESTS})
     string(REPLACE "UT.cpp" "" testCase ${testCaseFilename})
     set(testExe "${PROJECT_NAME}-${testCase}")
     alpaka_add_executable(${testExe} ${testCaseFilepath})
+    # Workaround for this bug https://github.com/nlohmann/json/issues/3907
+    # We don't need ranges in <nlohmann/json.hpp>
+    target_compile_definitions(${testExe} PRIVATE JSON_HAS_RANGES=0)
     target_link_libraries(${testExe} PUBLIC Catch2 Catch2WithMain)
     target_link_libraries(${testExe} PRIVATE pmacc::pmacc)
     if(${testExe} MATCHES ".*CLI.*")

test/picongpuHeaderCheck/CMakeLists.txt

@@ -105,6 +105,10 @@ alpaka_add_executable(
         ${_TARGET_NAME}
         ${_FILES_SOURCE})
 
+# Workaround for this bug https://github.com/nlohmann/json/issues/3907
+# We don't need ranges in <nlohmann/json.hpp>
+target_compile_definitions(${_TARGET_NAME} PRIVATE JSON_HAS_RANGES=0)
+
 target_link_libraries(${_TARGET_NAME} PUBLIC Catch2 Catch2WithMain)
 target_link_libraries(${_TARGET_NAME} PRIVATE pmacc::pmacc)
 target_include_directories(