Add ability to define additional puppet agent config settings

Author: cmd-ntrf

aws/infrastructure.tf

@@ -32,6 +32,7 @@ module "configuration" {
   cloud_provider  = local.cloud_provider
   cloud_region    = local.cloud_region
   skip_upgrade    = var.skip_upgrade
+  puppet_conf     = var.puppet_conf
 }
 
 module "provision" {

azure/infrastructure.tf

@@ -32,6 +32,7 @@ module "configuration" {
   cloud_provider  = local.cloud_provider
   cloud_region    = local.cloud_region
   skip_upgrade    = var.skip_upgrade
+  puppet_conf     = var.puppet_conf
 }
 
 module "provision" {

common/configuration/main.tf

@@ -9,6 +9,7 @@ locals {
 
 variable "config_git_url" {}
 variable "config_version" {}
+variable "puppet_conf" {}
 
 variable "sudoer_username" {}
 
@@ -92,6 +93,20 @@ locals {
     software_stack = var.software_stack,
   })
 
+  puppetservers = {
+    for host, values in var.inventory : host => try(values.local_ip, "") if contains(values.tags, "puppet")
+  }
+  puppet_conf = concat(
+    length(local.puppetservers) > 0 ? [
+      { key = "server", value = keys(local.puppetservers)[0], section = "main" }
+    ] : [],
+    [
+      { key = "waitforcert", value = "15s", section = "main" },
+      { key = "report", value = "true", section = "main" },
+      { key = "postrun_command", value = "/opt/puppetlabs/bin/postrun", section = "main" }
+    ],
+  )
+
   user_data = {
     for key, values in var.inventory : key =>
     templatefile("${path.module}/puppet.yaml.tftpl",
@@ -105,8 +120,9 @@ locals {
         domain_name           = var.domain_name
         puppetenv_git         = var.config_git_url,
         puppetenv_rev         = var.config_version,
-        puppetservers         = { for host, values in var.inventory : host => try(values.local_ip, "") if contains(values.tags, "puppet") }
+        puppetservers         = local.puppetservers
         puppetserver_password = local.puppet_passwd,
+        puppet_conf           = concat(local.puppet_conf, var.puppet_conf, [{ key = "certname", value = key, section = "main" }])
         sudoer_username       = var.sudoer_username,
         ssh_authorized_keys   = local.public_keys
         tf_ssh_public_key     = chomp(tls_private_key.ssh.public_key_openssh)

common/configuration/puppet.yaml.tftpl

@@ -134,13 +134,9 @@ runcmd:
 %{ endif ~}
   - chgrp puppet /etc/puppetlabs/puppet/csr_attributes.yaml
 %{ endif ~}
-%{ if length(puppetservers) > 0 ~}
-  - /opt/puppetlabs/bin/puppet config set server ${keys(puppetservers)[0]}
-%{ endif ~}
-  - /opt/puppetlabs/bin/puppet config set certname ${node_name}
-  - /opt/puppetlabs/bin/puppet config set waitforcert 15s
-  - /opt/puppetlabs/bin/puppet config set report true
-  - /opt/puppetlabs/bin/puppet config set postrun_command /opt/puppetlabs/bin/postrun
+%{ for conf in puppet_conf ~}
+  - ${jsonencode(["/opt/puppetlabs/bin/puppet", "config", "set", conf.key, conf.value, "--section", conf.section])}
+%{ endfor ~}
   - systemctl enable puppet
 # Remove all ifcfg configuration files that have no corresponding network interface in ip link show.
   - for i in /etc/sysconfig/network-scripts/ifcfg-*; do if ! ip link show | grep -q "$${i##*-}:"; then rm -f $i; fi; done

common/variables.tf

@@ -179,3 +179,13 @@ variable "bastion_tags" {
   default     = []
   description = "Tags identifying instances that can be used by Terraform as the first hop to transfer files to the Puppet server."
 }
+
+variable "puppet_conf" {
+  type = list(object({
+    key     = string
+    value   = string
+    section = optional(string, "main")
+  }))
+  default     = []
+  description = "List of additional settings for Puppet agent https://help.puppet.com/core/current/Content/PuppetCore/Markdown/configuration.htm"
+}

gcp/infrastructure.tf

@@ -32,6 +32,7 @@ module "configuration" {
   cloud_provider  = local.cloud_provider
   cloud_region    = local.cloud_region
   skip_upgrade    = var.skip_upgrade
+  puppet_conf     = var.puppet_conf
 }
 
 module "provision" {

incus/infrastructure.tf

@@ -28,6 +28,7 @@ module "configuration" {
   cloud_provider  = "incus"
   cloud_region    = "local"
   skip_upgrade    = var.skip_upgrade
+  puppet_conf     = var.puppet_conf
 }
 
 module "provision" {

openstack/infrastructure.tf

@@ -27,6 +27,7 @@ module "configuration" {
   cloud_provider  = local.cloud_provider
   cloud_region    = local.cloud_region
   skip_upgrade    = var.skip_upgrade
+  puppet_conf     = var.puppet_conf
 }
 
 module "provision" {