Skip to content

Remove redundant contains? in volume #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmd-ntrf merged 1 commit into from
Jun 11, 2026
Merged

Remove redundant contains? in volume #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions aws/infrastructure.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ locals {
ram = data.aws_ec2_instance_type.instance_type[values.prefix].memory_size
gpus = try(one(data.aws_ec2_instance_type.instance_type[values.prefix].gpus).count, 0)
}, values.specs)
volumes = contains(keys(module.design.volume_per_instance), x) ? {
volumes = {
for pv_key, pv_values in var.volumes :
pv_key => {
for name, specs in pv_values :
Expand All @@ -228,7 +228,7 @@ locals {
specs,
)
} if contains(values.tags, pv_key)
} : {}
}
}
}

Expand Down
4 changes: 2 additions & 2 deletions azure/infrastructure.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,7 @@ locals {
ram = local.vmsizes[values.type].ram
gpus = local.vmsizes[values.type].gpus
}, values.specs)
volumes = contains(keys(module.design.volume_per_instance), x) ? {
volumes = {
for pv_key, pv_values in var.volumes :
pv_key => {
for name, specs in pv_values :
Expand All @@ -185,7 +185,7 @@ locals {
specs,
)
} if contains(values.tags, pv_key)
} : {}
}
}
}

Expand Down
4 changes: 2 additions & 2 deletions gcp/infrastructure.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ locals {
ram = data.external.machine_type[values["prefix"]].result["ram"]
gpus = try(data.external.machine_type[values["prefix"]].result["gpus"], 0)
}, values.specs)
volumes = contains(keys(module.design.volume_per_instance), x) ? {
volumes = {
for pv_key, pv_values in var.volumes :
pv_key => {
for name, specs in pv_values :
Expand All @@ -191,7 +191,7 @@ locals {
specs,
)
} if contains(values.tags, pv_key)
} : {}
}
}
}

Expand Down
4 changes: 2 additions & 2 deletions openstack/infrastructure.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ locals {
parseint(split(":", lookup(data.openstack_compute_flavor_v2.flavors[values.type].extra_specs, "pci_passthrough:alias", "gpu:0"))[1], 10)
])
}, values.specs)
volumes = contains(keys(module.design.volume_per_instance), x) ? {
volumes = {
for pv_key, pv_values in var.volumes :
pv_key => {
for name, specs in pv_values :
Expand All @@ -152,7 +152,7 @@ locals {
specs,
)
} if contains(values.tags, pv_key)
} : {}
}
}
}

Expand Down
Loading