Skip to content

Commit da826bf

Browse files
Merge pull request #20 from ComputerDruid/push-uulrvxkuvlql
cleanup: clippy fixes
2 parents c055a9e + 71d989f commit da826bf

5 files changed

Lines changed: 16 additions & 17 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1 +1,2 @@
11
/target
2+
.zed

src/blueprint/upgrade_quality.rs

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -89,16 +89,14 @@ pub(crate) fn upgrade(mut json: serde_json::Value) -> serde_json::Value {
8989
WalkAction::Enter
9090
} else if NO_UPGRADE_PATHS.contains(&path) {
9191
WalkAction::Break
92+
} else if let Some(last) = path.last()
93+
&& last.contains("quality")
94+
{
95+
panic!(
96+
"Unhandled quality in blueprint; not sure whether we should upgrade:\n &{path:?},"
97+
);
9298
} else {
93-
if let Some(last) = path.last()
94-
&& last.contains("quality")
95-
{
96-
panic!(
97-
"Unhandled quality in blueprint; not sure whether we should upgrade:\n &{path:?},"
98-
);
99-
} else {
100-
WalkAction::Enter
101-
}
99+
WalkAction::Enter
102100
}
103101
});
104102
// upgrade_old(json)

src/main.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ enum Commands {
5050
mod terminal;
5151

5252
impl Commands {
53-
fn run(self) -> () {
53+
fn run(self) {
5454
match self {
5555
Commands::CountEntities {
5656
to_blueprint,
@@ -105,13 +105,13 @@ impl Commands {
105105
Commands::Unwrap { blueprint_string } => {
106106
let blueprint_string = blueprint_string.unwrap_or_else(terminal::prompt_blueprint);
107107
let json = blueprint_to_json(&blueprint_string);
108-
println!("{}", json);
108+
println!("{json}");
109109
}
110110
Commands::Wrap {} => {
111111
let mut buf = String::new();
112112
stdin().read_to_string(&mut buf).unwrap();
113113
let blueprint_string = json_to_blueprint(serde_json::from_str(&buf).unwrap());
114-
println!("{}", blueprint_string);
114+
println!("{blueprint_string}");
115115
}
116116
Commands::UpgradeQuality {
117117
to_clipboard,

src/save.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@ fn compute_name(json: &serde_json::Value) -> String {
9999
name.push_str(&name_part);
100100
}
101101
if iter.next().is_some() {
102-
name.push_str("…");
102+
name.push('…');
103103
}
104104
} else if let Some(blueprint) = json.get("upgrade_planner")
105105
&& let Some(settings) = blueprint.get("settings")
@@ -135,7 +135,7 @@ fn compute_name(json: &serde_json::Value) -> String {
135135
name.push_str(&name_part);
136136
}
137137
if iter.next().is_some() {
138-
name.push_str("…");
138+
name.push('…');
139139
}
140140
if !name.is_empty() {
141141
name = format!("Upgrade {name}");
@@ -172,7 +172,7 @@ pub fn save(mut json: serde_json::Value, dir: Option<&Path>) {
172172
&& let Some(blueprints) = blueprint_book.get_mut("blueprints")
173173
&& let Some(blueprints) = blueprints.as_array_mut()
174174
{
175-
let blueprints = mem::replace(blueprints, vec![]);
175+
let blueprints = mem::take(blueprints);
176176
let path = if let Some(dir) = dir {
177177
dir.join(&name)
178178
} else {

src/terminal.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ pub fn prompt_blueprint() -> String {
1414
crossterm::terminal::enable_raw_mode().unwrap();
1515
eprint!("Paste blueprint:\r\n");
1616
const PROMPT: &str = "🟦❯ ";
17-
eprint!("{}", PROMPT);
17+
eprint!("{PROMPT}");
1818
let mut warned = false;
1919
let blueprint_string = loop {
2020
let event = crossterm::event::read().unwrap();
@@ -29,7 +29,7 @@ pub fn prompt_blueprint() -> String {
2929
if !warned {
3030
warned = true;
3131
eprint!("\rWARN: Only pasting works.\r\n");
32-
eprint!("{}", PROMPT);
32+
eprint!("{PROMPT}");
3333
}
3434
}
3535
crossterm::event::Event::Paste(s) => {

0 commit comments

Comments
 (0)