Imagine using the wrong method to write to a stream

Author: ComputerElite

QuestAppVersionSwitcher/Assets/html/index.html

@@ -204,6 +204,10 @@ <h2>You can download mods and cosmetics from the following sites. Only QMods are
                     <div class="button" id="requestAppObbPermission">Request app obb permission</div>
                     <div class="buttonLabel">Requests permissions to access the currently selected apps obb directory</div>
                 </div>
+                <div class="buttonContainer">
+                    <div class="button" id="requestManageStorageAppPermission">Allow manage storage permission for selected app</div>
+                    <div class="buttonLabel">Opens settings to allow manage storage for the selected app</div>
+                </div>
                 <div class="buttonContainer">
                     <div class="button" id="checkUpdate">Check for QuestAppVersionSwitcher updates</div>
                     <div class="buttonLabel">Checks if updates for QuestAppVersionSwitcher exist</div>

QuestAppVersionSwitcher/Assets/html/script.js

@@ -712,6 +712,11 @@ document.getElementById("grantAccess").onclick = () => {
     })
 }
 
+document.getElementById("requestManageStorageAppPermission").onclick = () => {
+    fetch("grantmanagestorageappaccess?package=" + config.currentApp).then(res => {
+    })
+}
+
 document.getElementById("requestAppPermission").onclick = () => {
     fetch("grantaccess?package=" + config.currentApp).then(res => {
         res.text().then(text => {

QuestAppVersionSwitcher/FolderPermission.cs

@@ -17,7 +17,6 @@
 using Java.Util.Logging;
 using QuestAppVersionSwitcher.Core;
 using File = System.IO.File;
-using Logger = ComputerUtils.Android.Logging.Logger;
 
 namespace QuestAppVersionSwitcher
 {
@@ -30,7 +29,6 @@ public static void openDirectory(string dirInExtenalStorage)
             {
                 FileManager.CreateDirectoryIfNotExisting(dirInExtenalStorage);
             }
-            Logger.Log(RemapPathForApi300OrAbove(dirInExtenalStorage));
             Intent intent = new Intent(Intent.ActionOpenDocumentTree)
                 .PutExtra(
                     DocumentsContract.ExtraInitialUri,
@@ -41,7 +39,6 @@ public static void openDirectory(string dirInExtenalStorage)
         public static string RemapPathForApi300OrAbove(string path)
         {
             string suffix = path;
-            Logger.Log(suffix);
             if (suffix.StartsWith("/sdcard")) suffix = suffix.Substring("/sdcard".Length);
             if (path.StartsWith(Environment.ExternalStorageDirectory.AbsolutePath))
             {
@@ -57,33 +54,32 @@ public static string RemapPathForApi300OrAbove(string path)
         public static void Copy(string from, string to)
         {
             Stream file = GetOutputStream(to);
-            StreamWriter sw = new StreamWriter(file);
-            sw.Write(File.ReadAllBytes(from));
-            sw.Dispose();
+            file.Write(File.ReadAllBytes(from));
+            file.Close();
+            file.Dispose();
         }
 
         public static void CreateDirectory(string dir)
         {
             DocumentFile parent = GetAccessToFile(Directory.GetParent(dir).FullName);
-            Logger.Log(parent.CanWrite().ToString());
             parent.CreateDirectory(Path.GetFileName(dir));
         }
 
         /// <summary>
-        /// 
+        /// ONLY WORKS FOR /sdcard/Android/data/...!!!!!!!
         /// </summary>
         /// <param name="dir">Expected as /sdcard/Android/data/...</param>
         /// <returns></returns>
         public static DocumentFile GetAccessToFile(string dir)
         {
-            Logger.Log("Trying to get access to " + dir);
             string start = "/sdcard/Android/data/" + CoreService.coreVars.currentApp;
             string diff = dir.Replace(start + "/", "");
             string[] dirs = diff.Split('/');
             DocumentFile startDir = DocumentFile.FromTreeUri(AndroidCore.context, Uri.Parse(RemapPathForApi300OrAbove(start).Replace("com.android.externalstorage.documents/document/", "com.android.externalstorage.documents/tree/")));
             DocumentFile currentDir = startDir;
             foreach (string dirName in dirs)
             {
+                if (currentDir.FindFile(dirName) == null) currentDir.CreateDirectory(dirName); // Create directory if it doesn't exist
                 currentDir = currentDir.FindFile(dirName);
             }
             return currentDir;
@@ -106,7 +102,6 @@ public static void Delete(string path)
 
         public static void CreateDirectoryIfNotExisting(string path)
         {
-            Logger.Log("Creating directory " + path+ " if it doesn't exist");
             DocumentFile directory = GetAccessToFile(Directory.GetParent(path).FullName);
             string name = Path.GetFileName(path);
             if (directory.FindFile(name) == null) directory.CreateDirectory(name);
@@ -133,7 +128,6 @@ public void OnActivityResult(Object result)
             {
                 if (activityResult.Data.Data != null)
                 {
-                    Logger.Log(activityResult.Data.Data.ToString());
                     AndroidCore.context.ContentResolver.TakePersistableUriPermission(
                         activityResult.Data.Data,
                         ActivityFlags.GrantReadUriPermission | ActivityFlags.GrantWriteUriPermission);

QuestAppVersionSwitcher/Mods/QPMod.cs

@@ -125,7 +125,7 @@ private async Task Install(List<string> installedInBranch)
                 try
                 {
                     string dir = Directory.GetParent(k.Value).FullName;
-                    if (!Directory.Exists(dir)) FolderPermission.CreateDirectory(dir);
+                    FolderPermission.CreateDirectoryIfNotExisting(dir);
                     FolderPermission.Copy(k.Key, k.Value);
                     //File.Copy(k.Key, k.Value, true);
                 } catch(Exception e)

QuestAppVersionSwitcher/PatchingManager.cs

@@ -110,7 +110,7 @@ public static void PatchAPK(ZipArchive apkArchive, string appLocation)
             PatchManifest(apkArchive);
             Dictionary<string, ApkSigner.PrePatchHash>? prePatchHashes = AddLibs(apkArchive);
             apkArchive.Dispose();
-            QAVSWebserver.patchText = JsonSerializer.Serialize(new MessageAndValue<String>("Signing apk", ""));
+            QAVSWebserver.patchText = JsonSerializer.Serialize(new MessageAndValue<String>("Signing and aligning apk", ""));
 
             ApkSigner.SignApkWithPatchingCertificate(appLocation, prePatchHashes).Wait();
 

QuestAppVersionSwitcher/QuestPatcher/ApkAligner.cs

@@ -3,6 +3,7 @@
 using System.IO;
 using System.Linq;
 using System.Text;
+using ComputerUtils.Android.Logging;
 using QuestPatcher.Core.Apk;
 
 namespace QuestPatcher.Core
@@ -13,9 +14,9 @@ public class ApkAligner
 
         public static void AlignApk(string path)
         {
-            using FileStream fs = new FileStream(path, FileMode.Open);
-            using FileMemory memory = new FileMemory(fs);
-            using FileMemory outMemory = new FileMemory(new MemoryStream());
+            FileStream fs = new FileStream(path, FileMode.Open);
+            FileMemory memory = new FileMemory(fs);
+            FileMemory outMemory = new FileMemory(new MemoryStream());
             memory.Position = memory.Length() - 22;
             while(memory.ReadInt() != EndOfCentralDirectory.SIGNATURE)
             {
@@ -62,10 +63,15 @@ public static void AlignApk(string path)
             eocd.NumberOfCDsOnDisk = (short) cDs.Count;
             eocd.SizeOfCD = (int) (outMemory.Position - eocd.OffsetOfCD);
             eocd.Write(outMemory);
+            memory.Dispose();
+            Logger.Log("It's done! But copying to file...");
+            fs = new FileStream(path, FileMode.Open);
             fs.SetLength(0);
             outMemory.Stream.Position = 0;
             outMemory.Stream.CopyTo(fs);
             fs.Close();
+            fs.Dispose();
+            outMemory.Dispose();
         }
 
     }

QuestAppVersionSwitcher/WebServer.cs

@@ -30,6 +30,7 @@
 using System.Net;
 using System.Net.Sockets;
 using Android.OS;
+using Android.Provider;
 using Socket = System.Net.Sockets.Socket;
 using Java.Lang;
 using Exception = System.Exception;
@@ -828,6 +829,19 @@ public void Start()
                 serverRequest.SendString("", "text/plain", 200);
                 return true;
             }));
+            server.AddRoute("GET", "/grantmanagestorageappaccess", new Func<ServerRequest, bool>(serverRequest =>
+            {
+                if (serverRequest.queryString.Get("package") == null)
+                {
+                    serverRequest.SendString("package key needed", "text/plain", 400);
+                    return true;
+                }
+                string package = serverRequest.queryString.Get("package");
+                Intent intent = new Intent(Settings.ActionManageAppAllFilesAccessPermission, Android.Net.Uri.Parse("package:" + package));
+                AndroidCore.context.StartActivity(intent);
+                serverRequest.SendString("", "text/plain", 200);
+                return true;
+            }));
             server.AddRoute("GET", "/restoregamedata", new Func<ServerRequest, bool>(serverRequest =>
             {
                 if (serverRequest.queryString.Get("package") == null)