Skip to content

Commit 30ff53e

Browse files
committed
Rebased with dev and fixed issues that resulted from that
1 parent 0dbf574 commit 30ff53e

File tree

11 files changed

+19
-274
lines changed

11 files changed

+19
-274
lines changed

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ ENV PORT=${PORT}
3535
EXPOSE ${PORT}
3636

3737
COPY conditional /opt/conditional/conditional
38-
COPY *.py package.json /opt/conditional
39-
COPY --from=build-frontend /opt/conditional/conditional/static /opt/conditional/conditional/static
38+
COPY *.py package.json /opt/conditional/
39+
COPY --from=build-frontend /opt/conditional/conditional/static/ /opt/conditional/conditional/static/
4040

4141
RUN ln -sf /usr/share/zoneinfo/America/New_York /etc/localtime
4242

conditional/blueprints/major_project_submission.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,9 @@
11
import json
22
import os
3-
import requests
4-
53
import requests
64
import boto3
75

6+
from conditional.models.models import MajorProject, MajorProjectSkill
87
from config import AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY
98
from flask import Blueprint
109
from flask import request
@@ -18,8 +17,6 @@
1817

1918
from conditional.util.context_processors import get_member_name
2019

21-
from conditional.models.models import MajorProject, MajorProjectSkill
22-
2320
from conditional.util.ldap import ldap_is_eval_director
2421
from conditional.util.ldap import ldap_get_member
2522
from conditional.util.flask import render_template
@@ -55,7 +52,7 @@ def display_major_project(user_dict=None):
5552
MajorProject.id == MajorProjectSkill.project_id
5653
).group_by(MajorProject.id
5754
).where(MajorProject.date >= start_of_year()
58-
).order_by(desc(MajorProject.date))
55+
).order_by(MajorProject.date)
5956

6057
major_projects = [
6158
{
@@ -133,7 +130,7 @@ def submit_major_project(user_dict=None):
133130

134131
# All fields are required in order to be able to submit the form
135132
# TODO: Do we want any of the fields to have enforced min or max lengths?
136-
if name == "" or tldr == "" or time_spent == "" or skills == "" or description == "":
133+
if not name or not tldr or not time_spent or not description:
137134
return jsonify({"success": False}), 400
138135

139136
# TODO: Ensure all the information is being passed to the object
@@ -144,11 +141,13 @@ def submit_major_project(user_dict=None):
144141
db.session.commit()
145142

146143

144+
# project_id = project.id
147145
project = MajorProject.query.filter(
148-
MajorProject.name == name and MajorProject.uid == user_id
146+
MajorProject.name == name,
147+
MajorProject.uid == user_id
149148
).first()
150149

151-
skills_list = filter(lambda x: x != 'None', skills)
150+
skills_list = list(filter(lambda x: x != 'None', skills))
152151
print(f"Skills: {list(skills_list)}")
153152

154153
for skill in skills_list:

frontend/javascript/modules/majorProjectForm.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,8 @@ export default class MajorProjectForm {
5252

5353
Array.from(this.form.getElementsByClassName('skill-tag')).forEach(tag => skills.push(tag.firstChild.data))
5454

55+
console.log("Links: " + this.form.querySelector('textarea[name=links]').value);
56+
5557
let payload = {
5658
projectName: this.form.querySelector('input[name=name]').value,
5759
projectTldr: this.form.querySelector('input[name=tldr]').value,

migrations/versions/217b5842448c_.py

Lines changed: 0 additions & 26 deletions
This file was deleted.
Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,13 @@
1-
"""add new fields to major project form
1+
"""empty message
22
3-
Revision ID: 09603d1cfc38
3+
Revision ID: 6c4cf35d7c0c
44
Revises: f1d08673b870
5-
Create Date: 2026-03-01 10:46:33.652106
5+
Create Date: 2026-03-06 15:42:50.323042
66
77
"""
88

99
# revision identifiers, used by Alembic.
10-
revision = '09603d1cfc38'
10+
revision = '6c4cf35d7c0c'
1111
down_revision = 'f1d08673b870'
1212

1313
from alembic import op

migrations/versions/72444bd2437e_.py

Lines changed: 0 additions & 41 deletions
This file was deleted.

migrations/versions/8182939744c8_.py

Lines changed: 0 additions & 39 deletions
This file was deleted.

migrations/versions/82cdb94fc915_.py

Lines changed: 0 additions & 26 deletions
This file was deleted.

migrations/versions/e2673b9e9ea8_.py

Lines changed: 0 additions & 34 deletions
This file was deleted.

0 commit comments

Comments
 (0)