Automatically add 2 housing points when user passes spring evals (#511)

* Automatically add 2 housing points when user passes spring evals

* Housing points properly added on passed spring evals conditional

* Fixed thing

---------

Co-authored-by: Noah Hanford <spaced@csh.rit.edu>

Author: pikachu0542

.gitignore

@@ -69,6 +69,9 @@ target/
 # Cloud9 IDE
 /.c9
 
+# VS Codepy
+.vscode/
+
 # Sensitive project files
 /config.json
 /config.py

conditional/blueprints/conditional.py

@@ -7,6 +7,7 @@
 from conditional.models.models import Conditional, SpringEval, FreshmanEvalData
 from conditional.util.auth import get_user
 from conditional.util.flask import render_template
+from conditional.util.ldap import ldap_get_member, ldap_set_housingpoints
 from conditional.util.user_dict import user_dict_is_eval_director
 
 conditionals_bp = Blueprint('conditionals_bp', __name__)
@@ -91,6 +92,7 @@ def conditional_review(user_dict=None):
     log.info(f'Updated conditional-{cid} to {status}')
     conditional = Conditional.query.filter(Conditional.id == cid)
     cond_obj = conditional.first()
+    uid = cond_obj.uid
 
     conditional.update(
         {
@@ -101,6 +103,12 @@ def conditional_review(user_dict=None):
             {
                 'status': status
             })
+
+        if status == 'Passed':
+            account = ldap_get_member(uid)
+            hp = account.housingPoints
+            ldap_set_housingpoints(account, hp + 2)
+
     elif cond_obj.i_evaluation:
         FreshmanEvalData.query.filter(FreshmanEvalData.id == cond_obj.i_evaluation).update(
             {

conditional/blueprints/slideshow.py

@@ -11,7 +11,7 @@
 from conditional.models.models import SpringEval
 from conditional.util.auth import get_user
 from conditional.util.flask import render_template
-from conditional.util.ldap import ldap_is_intromember, ldap_set_failed, ldap_set_bad_standing, \
+from conditional.util.ldap import ldap_is_intromember, ldap_set_failed, ldap_set_bad_standing, ldap_set_housingpoints, \
     ldap_set_inactive, ldap_get_member, ldap_set_not_intro_member
 from conditional.util.user_dict import user_dict_is_eval_director
 
@@ -137,6 +137,9 @@ def slideshow_spring_review(user_dict=None):
     if status == "Passed":
         if ldap_is_intromember(account):
             ldap_set_not_intro_member(account)
+
+        hp = account.housingPoints
+        ldap_set_housingpoints(account, hp + 2)
     elif status == "Failed":
         if ldap_is_intromember(account):
             ldap_set_failed(account)