Fix a sonarqube issue

Author: pikachu0542

conditional/blueprints/major_project_submission.py

@@ -38,11 +38,11 @@ def display_major_project(user_dict=None):
     log.info("Display Major Project Page")
 
     # There is probably a better way to do this, but it does work
-    proj_list = get_project_list()
+    proj_list: list = get_project_list()
 
-    bucket = app.config['S3_BUCKET_ID']
+    bucket: str = app.config['S3_BUCKET_ID']
 
-    major_projects = [
+    major_projects: list[dict] = [
         {
             "id": p.id,
             "date": p.date,
@@ -61,12 +61,11 @@ def display_major_project(user_dict=None):
         for p in proj_list
     ]
 
-    major_projects_len = len(major_projects)
     # return names in 'first last (username)' format
     return render_template(
         "major_project_submission.html",
         major_projects=major_projects,
-        major_projects_len=major_projects_len,
+        major_projects_len=len(major_projects),
         username=user_dict["username"])
 
 @major_project_bp.route("/major_project/upload", methods=["POST"])
@@ -82,7 +81,7 @@ def upload_major_project_files(user_dict=None):
     # Temporarily save files to a place, to be uploaded on submit
     for _, file in request.files.lists():
         file = file[0]
-        safe_name = secure_filename(file.filename)
+        safe_name: str = secure_filename(file.filename)
         filename = f"/tmp/{user_dict['username']}/{safe_name}"
 
         os.makedirs(os.path.dirname(filename), exist_ok=True)
@@ -152,7 +151,7 @@ def submit_major_project(user_dict=None):
                         endpoint_url=app.config['S3_URI'])
 
     # Collect all the locally cached files and put them in the bucket
-    temp_dir = f"/tmp/{user_id}"
+    temp_dir: str = f"/tmp/{user_id}"
     if os.path.exists(temp_dir):
         for file in os.listdir(temp_dir):
             filepath = f"{temp_dir}/{file}"

conditional/templates/major_project_submission.html

@@ -67,7 +67,7 @@ <h3 class="mb-4">Major Project Form</h3>
                 <div class="row mt-3">
                     <div class="col-lg-6">
 
-                        <label class="d-block h5 mt-4 mb-2">
+                        <label for="skill-input" class="d-block h5 mt-4 mb-2">
                             Skills Applied &MediumSpace;
                             <small class="text-muted d-block">
                                 Press Enter or , to separate skills
@@ -76,12 +76,12 @@ <h3 class="mb-4">Major Project Form</h3>
 
                         <div class="form-control border-0 border-bottom rounded-0 p-2">
                             <input
-                            id="skill-input"
-                            name="skill"
-                            type="text"
-                            maxlength="16"
-                            placeholder="Add a skill"
-                            class="border-0 w-100"
+                                id="skill-input"
+                                name="skill"
+                                type="text"
+                                maxlength="16"
+                                placeholder="Add a skill"
+                                class="border-0 w-100"
                             >
                             <small class="text-muted">
                                 List what skills you meaningfully used while working on this project (at least 2!)
@@ -95,11 +95,11 @@ <h3 class="mb-4">Major Project Form</h3>
                         </label>
 
                         <textarea
-                        id="time-commitment"
-                        name="time-commitment"
-                        rows="4"
-                        class="form-control form-textarea"
-                        placeholder="We're looking for a considerable amount of time spent on your major project, we suggest ~10 hours minimum"
+                            id="time-commitment"
+                            name="time-commitment"
+                            rows="4"
+                            class="form-control form-textarea"
+                            placeholder="We're looking for a considerable amount of time spent on your major project, we suggest ~10 hours minimum"
                         ></textarea>
                     </div>
                 </div>
@@ -109,11 +109,11 @@ <h3 class="mb-4">Major Project Form</h3>
                 </label>
 
                 <textarea
-                id="description"
-                name="description"
-                rows="6"
-                class="form-control mb-extra"
-                placeholder="Tell us everything! More information is better than less."
+                    id="description"
+                    name="description"
+                    rows="6"
+                    class="form-control mb-extra"
+                    placeholder="Tell us everything! More information is better than less."
                 ></textarea>
 
                 <div class="row mt-3">
@@ -123,11 +123,11 @@ <h3 class="mb-4">Major Project Form</h3>
                         </label>
 
                         <textarea
-                        id="links"
-                        name="links"
-                        rows="2"
-                        class="form-control form-textarea"
-                        placeholder="If you have links (GitHub, YouTube, etc.), put them here!"
+                            id="links"
+                            name="links"
+                            rows="2"
+                            class="form-control form-textarea"
+                            placeholder="If you have links (GitHub, YouTube, etc.), put them here!"
                         ></textarea>
                     </div>