Skip to content

Commit f94799a

Browse files
authored
Merge pull request #493 from ComputerScienceHouse/fix-shit
Fix shit
2 parents b4fe087 + 12ee144 commit f94799a

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

conditional/blueprints/intro_evals.py

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
from datetime import datetime
2-
31
import structlog
42
from flask import Blueprint, request
53
from sqlalchemy import func
@@ -82,8 +80,7 @@ def get_intro_members_without_accounts():
8280

8381
# freshmen who don't have accounts
8482
freshman_accounts = list(FreshmanAccount.query.filter(
85-
FreshmanAccount.eval_date > semester_start,
86-
FreshmanAccount.eval_date > datetime.now()))
83+
FreshmanAccount.eval_date >= semester_start))
8784

8885
ie_members = []
8986

@@ -124,6 +121,8 @@ def get_intro_members_without_accounts():
124121
}
125122
ie_members.append(freshman)
126123

124+
print(ie_members)
125+
127126
return ie_members
128127

129128
@intro_evals_bp.route('/intro_evals/')
@@ -197,7 +196,7 @@ def display_intro_evals(internal=False, user_dict=None):
197196
uid = member.uid
198197
name = member.cn
199198
freshman_data = FreshmanEvalData.query.filter(
200-
FreshmanEvalData.eval_date > semester_start,
199+
FreshmanEvalData.eval_date >= semester_start,
201200
FreshmanEvalData.uid == uid).first()
202201

203202
if freshman_data is None:

conditional/util/member.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,12 @@ def get_hm(member, only_absent=False):
143143
return h_meetings
144144

145145

146-
@service_cache(maxsize=128)
146+
# @service_cache(maxsize=128) # Can't hash because members_on_coop is a list
147147
def req_cm(uid, members_on_coop=None):
148148
# Get the number of required committee meetings based on if the member
149149
# is going on co-op in the current operating session.
150150
on_coop = False
151+
151152
if members_on_coop:
152153
on_coop = uid in members_on_coop
153154
else:
@@ -162,9 +163,9 @@ def req_cm(uid, members_on_coop=None):
162163

163164

164165
def is_gatekeep_active():
165-
today = datetime.today()
166-
before_evals_one = len(FreshmanAccount.query.filter(FreshmanAccount.eval_date > today).limit(1).all())
167-
before_evals_two = len(FreshmanEvalData.query.filter(FreshmanEvalData.eval_date > today).limit(1).all())
166+
today = datetime.today().date()
167+
before_evals_one = len(FreshmanAccount.query.filter(FreshmanAccount.eval_date >= today).limit(1).all())
168+
before_evals_two = len(FreshmanEvalData.query.filter(FreshmanEvalData.eval_date >= today).limit(1).all())
168169

169170
return not (before_evals_one > 0 or before_evals_two > 0)
170171

0 commit comments

Comments
 (0)