fix: lint

Author: costowell

gunicorn_conf.py

@@ -1,5 +1,6 @@
+"""Gunicorn configuration for self-service application."""
+
 import os
-import subprocess
 
 from flask_sqlalchemy import SQLAlchemy
 from flask_migrate import Migrate, upgrade
@@ -8,16 +9,17 @@
 app = Flask(__name__)
 
 if os.path.exists(os.path.join(os.getcwd(), "config.py")):
-	app.config.from_pyfile(os.path.join(os.getcwd(), "config.py"))
+    app.config.from_pyfile(os.path.join(os.getcwd(), "config.py"))
 else:
-	app.config.from_pyfile(os.path.join(os.getcwd(), "config.env.py"))
+    app.config.from_pyfile(os.path.join(os.getcwd(), "config.env.py"))
 
 # Create the database session and import models.
 db = SQLAlchemy(app)
-from selfservice.models import *
+from selfservice.models import *  # noqa: F403,E402  # pylint: disable=wrong-import-position,unused-wildcard-import,wildcard-import
 migrate = Migrate(app, db)
 
-def on_starting(server):
-	if not os.path.exists(os.path.join(os.getcwd(), "data.db")):
-		with app.app_context():
-			upgrade()
+
+def on_starting(_server):  # pylint: disable=missing-function-docstring
+    if not os.path.exists(os.path.join(os.getcwd(), "data.db")):
+        with app.app_context():
+            upgrade()

selfservice/blueprints/recovery.py

@@ -2,26 +2,25 @@
 Flask blueprint for handling identity verification and account recovery.
 """
 
-import phonenumbers
 import datetime
-import uuid
 import logging
+import uuid
 
+import phonenumbers
 from flask import Blueprint, render_template, request, redirect, flash
+from flask import current_app
 from flask import session as flask_session
+from twilio.rest import Client
 
+from selfservice import db, auth, xcaptcha, ldap, version, OIDC_PROVIDER
+from selfservice.models import RecoverySession, PhoneVerification, ResetToken
 from selfservice.utilities.general import email_recovery, phone_recovery
+from selfservice.utilities.ldap import verif_methods, get_members
 from selfservice.utilities.reset import (
     generate_token,
     passwd_reset,
     TokenAlreadyExists,
 )
-from selfservice.utilities.ldap import verif_methods, get_members
-from twilio.rest import Client
-from flask import current_app
-
-from selfservice.models import RecoverySession, PhoneVerification, ResetToken
-from selfservice import db, auth, xcaptcha, ldap, version, OIDC_PROVIDER
 
 LOG = logging.getLogger(__name__)
 

selfservice/utilities/general.py

@@ -57,4 +57,4 @@ def phone_recovery(phone):
     verification = client.verify.v2.services(service_sid).verifications.create(
         channel="sms", to=phone
     )
-    LOG.info(f"Verification sent: {verification}")
+    LOG.info("Verification sent: %s", verification)

selfservice/utilities/reset.py

@@ -2,13 +2,12 @@
 Functions relating to the verification of users and subsequent account resets.
 """
 
-import random
 import uuid
 import requests
 import ldap
 import srvlookup
 
-from selfservice.models import ResetToken, PhoneVerification
+from selfservice.models import ResetToken
 from selfservice import db, app