Revert "Dev (#56)"

This reverts commit 5e6f38d.

Author: shaeespring

.github/dependabot.yml

@@ -2,12 +2,11 @@ FROM docker.io/golang:1.24-alpine AS build
 
 WORKDIR /src/
 RUN apk add git
-COPY go.* .
-RUN go mod download # do this before build for caching
+COPY go* .
+COPY *.go .
 COPY database database
 COPY logging logging
 COPY sse sse
-COPY *.go .
 RUN go build -v -o vote
 
 FROM docker.io/alpine

.github/pull_request_template.md

@@ -11,9 +11,7 @@ Implementation
 
 ## Configuration
 
-If you're using the compose file, you'll need to ask an RTP for the vote-dev OIDC secret, and set it as `VOTE_OIDC_SECRET` in your environment
-
-If you're not using the compose file, you'll need more of these
+You'll need to set up these values in your environment. Ask an RTP for OIDC credentials. A docker-compose file is provided for convenience. Otherwise, I trust you to figure it out!
 
 ```
 VOTE_HOST=http://localhost:8080
@@ -29,34 +27,10 @@ VOTE_SLACK_APP_TOKEN=
 VOTE_SLACK_BOT_TOKEN=
 ```
 
-### Dev Overrides
-`DEV_DISABLE_ACTIVE_FILTERS="true"` will disable the requirements that you be active to vote
-`DEV_FORCE_IS_EVALS="true"` will force vote to treat all users as the Evals director
-
-## Linting
-These will be checked by CI
-
-```
-# tidy dependencies
-go mod tidy
-
-# format all code according to go standards
-gofmt -w -s *.go logging sse database
-
-# run tests (database is the first place we've defined tests)
-go test ./database
-
-# run heuristic validation
-go vet ./database/ ./logging/ ./sse/
-go vet *.go
-```
-
 ## To-Dos
 
 - [ ] Don't let the user fuck it up
 - [ ] Show E-Board polls with a higher priority
-- [x] Move Hide Vote to create instead of after you vote :skull:
+- [ ] Move Hide Vote to create instead of after you vote :skull:
 - [ ] Display the reason why a user is on the results page of a running poll
 - [ ] Display minimum time left that a poll is open
-- [ ] Move routes to their own functions 
-- [ ] Change HTTP resposne codes to be `http.something` instead of just a number

.github/workflows/go.yaml

@@ -151,14 +151,8 @@ func EvaluatePolls() {
 			logging.Logger.WithFields(logrus.Fields{"method": "EvaluatePolls close"}).Error(err)
 			continue
 		}
-		announceStr := "The vote \"" + poll.ShortDescription + "\" has closed."
-		if !poll.Hidden {
-			announceStr += " Check out the results at " + pollLink
-		} else {
-			announceStr += " Results will be posted shortly."
-		}
 		_, _, _, err = slackData.Client.SendMessage(slackData.AnnouncementsChannel,
-			slack.MsgOptionText(announceStr, false))
+			slack.MsgOptionText("The vote \""+poll.ShortDescription+"\" has closed. Check out the results at "+pollLink, false))
 		if err != nil {
 			logging.Logger.WithFields(logrus.Fields{"method": "EvaluatePolls announce"}).Error(err)
 		}

.github/workflows/sonarqube.yml

@@ -4,7 +4,6 @@ import (
 	"context"
 	"os"
 	"strings"
-	"testing"
 	"time"
 
 	"github.com/computersciencehouse/vote/logging"
@@ -21,16 +20,10 @@ const (
 	Updated UpsertResult = 1
 )
 
-var Client *mongo.Client = Connect()
+var Client = Connect()
 var db = ""
 
 func Connect() *mongo.Client {
-	// This always gets invoked on initialisation. bad! it'd be nice if we only did this setup in main rather than components under test. for now we just skip if testing
-	if testing.Testing() {
-		logging.Logger.WithFields(logrus.Fields{"module": "database", "method": "Connect"}).Info("testing, not doing db connection, someone should mock this someday")
-		return nil
-	}
-
 	logging.Logger.WithFields(logrus.Fields{"module": "database", "method": "Connect"}).Info("beginning database connection")
 
 	ctx, cancel := context.WithTimeout(context.TODO(), 10*time.Second)