Run go vet

Author: mxmeinhold

.github/workflows/go.yaml

@@ -32,3 +32,7 @@ jobs:
       - name: Run Tests
         run: |
           go test ./database
+      - name: Run vet
+        run: |
+          go vet ./database/ ./logging/ ./sse/
+          go vet *.go

README.md

@@ -45,6 +45,10 @@ gofmt -w -s *.go logging sse database
 
 # run tests (database is the first place we've defined tests)
 go test ./database
+
+# run heuristic validation
+go vet ./database/ ./logging/ ./sse/
+go vet *.go
 ```
 
 ## To-Dos

database/poll.go

@@ -143,32 +143,32 @@ func GetClosedVotedPolls(ctx context.Context, userId string) ([]*Poll, error) {
 
 	cursor, err := Client.Database(db).Collection("votes").Aggregate(ctx, mongo.Pipeline{
 		{{
-			"$match", bson.D{
-				{"userId", userId},
+			Key: "$match", Value: bson.D{
+				{Key: "userId", Value: userId},
 			},
 		}},
 		{{
-			"$lookup", bson.D{
-				{"from", "polls"},
-				{"localField", "pollId"},
-				{"foreignField", "_id"},
-				{"as", "polls"},
+			Key: "$lookup", Value: bson.D{
+				{Key: "from", Value: "polls"},
+				{Key: "localField", Value: "pollId"},
+				{Key: "foreignField", Value: "_id"},
+				{Key: "as", Value: "polls"},
 			},
 		}},
 		{{
-			"$unwind", bson.D{
-				{"path", "$polls"},
-				{"preserveNullAndEmptyArrays", false},
+			Key: "$unwind", Value: bson.D{
+				{Key: "path", Value: "$polls"},
+				{Key: "preserveNullAndEmptyArrays", Value: false},
 			},
 		}},
 		{{
-			"$replaceRoot", bson.D{
-				{"newRoot", "$polls"},
+			Key: "$replaceRoot", Value: bson.D{
+				{Key: "newRoot", Value: "$polls"},
 			},
 		}},
 		{{
-			"$match", bson.D{
-				{"open", false},
+			Key: "$match", Value: bson.D{
+				{Key: "open", Value: false},
 			},
 		}},
 	})
@@ -293,15 +293,15 @@ func (poll *Poll) GetResult(ctx context.Context) ([]map[string]int, error) {
 		pollResult := make(map[string]int)
 		cursor, err := Client.Database(db).Collection("votes").Aggregate(ctx, mongo.Pipeline{
 			{{
-				"$match", bson.D{
-					{"pollId", pollId},
+				Key: "$match", Value: bson.D{
+					{Key: "pollId", Value: pollId},
 				},
 			}},
 			{{
-				"$group", bson.D{
-					{"_id", "$option"},
-					{"count", bson.D{
-						{"$sum", 1},
+				Key: "$group", Value: bson.D{
+					{Key: "_id", Value: "$option"},
+					{Key: "count", Value: bson.D{
+						{Key: "$sum", Value: 1},
 					}},
 				},
 			}},
@@ -328,8 +328,8 @@ func (poll *Poll) GetResult(ctx context.Context) ([]map[string]int, error) {
 		// Get all votes
 		cursor, err := Client.Database(db).Collection("votes").Aggregate(ctx, mongo.Pipeline{
 			{{
-				"$match", bson.D{
-					{"pollId", pollId},
+				Key: "$match", Value: bson.D{
+					{Key: "pollId", Value: pollId},
 				},
 			}},
 		})

database/poll_test.go

@@ -217,7 +217,8 @@ func TestOrderOptions(t *testing.T) {
 
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {
-			ctx, _ := context.WithTimeout(context.Background(), time.Second)
+			ctx, cancel := context.WithTimeout(context.Background(), time.Second)
+			defer cancel()
 			assert.Equal(t, test.output, orderOptions(ctx, test.input))
 		})
 	}