Skip to content

Commit bee077f

Browse files
committed
raise minimum go version to 1.26
1 parent 81fdc5b commit bee077f

5 files changed

Lines changed: 11 additions & 16 deletions

File tree

.github/workflows/citest.yml

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3,19 +3,15 @@ on:
33
push:
44
pull_request:
55

6-
# set go version for all steps
7-
env:
8-
GOVERSION: 1.23.x
9-
106
jobs:
117
test:
128
runs-on: ubuntu-latest
139
steps:
1410
- uses: actions/checkout@v6
1511
- name: Install Go
16-
uses: actions/setup-go@v5
12+
uses: actions/setup-go@v6
1713
with:
18-
go-version: ${{ env.GOVERSION }}
14+
go-version-file: './go.mod'
1915
- run: make clean
2016
- run: make citest
2117
- run: make
@@ -31,11 +27,10 @@ jobs:
3127
steps:
3228
- uses: actions/checkout@v6
3329
- name: Install Go
34-
uses: actions/setup-go@v5
30+
uses: actions/setup-go@v6
3531
with:
36-
go-version: ${{ env.GOVERSION }}
32+
go-version-file: './go.mod'
3733
- run: |
38-
echo "Testing with ${{ env.GOVERSION }}"
3934
go work init
4035
go work use .
4136
$Env:GOWORK = "off"

Changes

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,8 @@
11
This file documents the revision history for check_nsc_web
22

3+
next:
4+
- minimum go version is now 1.26
5+
36
0.7.5 Tue Apr 7 16:15:20 CEST 2026
47
- Add environment variables for sensitive information that should not be passed through command line: password, login and timeout
58
- update dependencies

buildtools/go.mod

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
module tools
22

3-
go 1.23.0
4-
5-
toolchain go1.24.4
3+
go 1.26
64

75
require (
86
github.com/daixiang0/gci v0.13.6

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
module github.com/consol-monitoring/check_nsc_web
22

3-
go 1.23
3+
go 1.26
44

55
require github.com/stretchr/testify v1.11.1
66

pkg/checknscweb/check_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ package checknscweb
22

33
import (
44
"bytes"
5-
"context"
65
"os"
76
"path/filepath"
87
"testing"
@@ -12,7 +11,7 @@ import (
1211
)
1312

1413
func TestCheck(t *testing.T) {
15-
ctx := context.TODO()
14+
ctx := t.Context()
1615
buf := &bytes.Buffer{}
1716

1817
exitCode := Check(ctx, buf, []string{"-h"}, nil)
@@ -28,7 +27,7 @@ func TestCheck(t *testing.T) {
2827
}
2928

3029
func TestCheckConfig(t *testing.T) {
31-
ctx := context.TODO()
30+
ctx := t.Context()
3231
buf := &bytes.Buffer{}
3332
tmpFile := filepath.Join(t.TempDir(), "config")
3433

0 commit comments

Comments
 (0)