Merge pull request #37 from jstark1/vmtools_upgrade

Check vmtools upgrade status and format output

Author: datamuc

checkvsphere/vcmd/vmtools.py

@@ -49,6 +49,14 @@ def run():
     parser.add_optional_arguments(CheckArgument.ALLOWED(
         'regex, checked against <vm-name>'
     ))
+    parser.add_optional_arguments({
+        'name_or_flags': ['--old'],
+        'options': {
+            'action': 'store_true',
+            'default': False,
+            'help': 'tools that are too old generate a warning now',
+        }
+    })
     parser.add_optional_arguments({
         'name_or_flags': ['--not-installed'],
         'options': {
@@ -135,6 +143,11 @@ def run():
                 logging.debug(f"{name} has no vm tools installed")
                 if args.not_installed:
                     check.add_message(Status.CRITICAL, f"{name} tools not installed")
+            elif guest_summary.toolsStatus == "toolsOld":
+                perf_data["VMware Tools upgrade available"] += 1
+                logging.debug(f"{name} tools upgrade available")
+                if args.old:
+                    check.add_message(Status.WARNING, f"{name} tools upgrade available")
             elif guest_summary.toolsRunningStatus == "guestToolsNotRunning":
                 perf_data["VMware Tools not running"] += 1
                 check.add_message(Status.CRITICAL, f"{name} tools not running")