check_tasksched: add default values of arguments in their descriptions

hidden arg is default false in the script as well

fix some other typos/dead code

Author: inqrphl

pkg/snclient/check_tasksched.go

@@ -42,11 +42,16 @@ func (l *CheckTasksched) Build() *CheckData {
 			State: CheckExitOK,
 		},
 		args: map[string]CheckArgument{
-			"timezone":  {description: "Sets the timezone for time metrics (default is local time)"},
-			"title":     {value: &l.TaskTitle, description: "Sets the task to check. This corresonds to the title of the scheduled task, called TaskName in Powershell output."},
-			"folder":    {value: &l.Folder, description: "The folder where the scheduled task is saved. This is used for exact matches, unless recurisive option is enabled."},
-			"recursive": {value: &l.Recursive, description: "Include the subfolders of the specified folder as well when searching for scheduled tasks."},
-			"hidden":    {value: &l.Hidden, description: "Include hidden tasks."},
+			"timezone": {description: "Sets the timezone for time metrics (default is local time)"},
+			"title": {value: &l.TaskTitle,
+				description: fmt.Sprintf("Sets the task to check. This corresonds to the title of the scheduled task. Default: '%s'", CheckTaskschedDefaultTaskTitle)},
+			"folder": {value: &l.Folder,
+				description: fmt.Sprintf("The folder where the scheduled task is saved. This is used for exact matches, unless recurisive option is enabled. Default: '%s'",
+					CheckTaskschedDefaultFolder)},
+			"recursive": {value: &l.Recursive,
+				description: fmt.Sprintf("Include the subfolders of the specified folder as well when searching for scheduled tasks. Default: '%t'", CheckTaskschedDefaultRecursive)},
+			"hidden": {value: &l.Hidden,
+				description: fmt.Sprintf("Include hidden tasks. Default: '%t'", CheckTaskschedDefaultHidden)},
 		},
 		defaultFilter:   "enabled = true",
 		defaultCritical: "exit_code < 0",

pkg/snclient/condition.go

@@ -841,7 +841,6 @@ func (c *Condition) expandUnitByType(str string) error {
 		c.unit = ""
 
 		return nil
-	default:
 	}
 
 	match := reConditionValueUnit.FindStringSubmatch(str)
@@ -887,8 +886,6 @@ func (c *Condition) expandUnitByType(str string) error {
 		c.unit = "s"
 
 		return nil
-	case UBool:
-		return nil // handled before the regex check
 	case UPercent:
 		return nil
 	case UNone:

pkg/snclient/embed/scripts/windows/scheduled_tasks.ps1

@@ -36,7 +36,7 @@ if ($args) {
 if (!$title) { $title = '*' }
 if (!$folder) { $folder = '\' }
 if (!$recursive) { $recursive = 'true' }
-if (!$hidden) { $hidden = 'true' }
+if (!$hidden) { $hidden = 'false' }
 
 # debug the parameters/arguments
 [Console]::Error.WriteLine(('title: ' + $title ))

pkg/utils/utils.go

@@ -133,7 +133,7 @@ func ParseAndReplaceBoolAttributes(val string) (newVal, oldVal string, err error
 	})
 
 	if foundValues == 0 {
-		err = fmt.Errorf("ParseAndReplaceBoolAttributes: did not find any truthy or falsely values in boolean attribute value: '%s' , lowercase needs to be one of falsely: '%s' or truthy: '%s' values",
+		err = fmt.Errorf("ParseAndReplaceBoolAttributes: did not find any truthy or falsey values in boolean attribute value: '%s' , lowercase needs to be one of falsey: '%s' or truthy: '%s' values",
 			val, strings.Join(falseyValues, " "), strings.Join(truthyValues, " "))
 	}