change the default empty state to ok

differentiate between empty states
1) where no files are found, due to given file paths
2) where files are found but do not contain matched lines.

write different outputs for both of them, and add tests

Author: Ahmet Oeztuerk

docs/checks/commands/check_logfile.md

@@ -58,7 +58,7 @@ Naemon Config
 
 | Argument      | Default Value                                                          |
 | ------------- | ---------------------------------------------------------------------- |
-| empty-state   | 3 (UNKNOWN)                                                            |
+| empty-state   | 0 (OK)                                                                 |
 | empty-syntax  | %(status) - No files found                                             |
 | top-syntax    | %(status) - %(problem_count)/%(count) lines (%(count)) %(problem_list) |
 | ok-syntax     | %(status) - All %(count) / %(total) Lines OK                           |

pkg/snclient/check_logfile.go

@@ -67,7 +67,7 @@ func (c *CheckLogFile) Build() *CheckData {
 		okSyntax:     "%(status) - All %(count) / %(total) Lines OK",
 		topSyntax:    "%(status) - %(problem_count)/%(count) lines (%(count)) %(problem_list)",
 		emptySyntax:  "%(status) - No files found",
-		emptyState:   CheckExitUnknown,
+		emptyState:   CheckExitOK,
 		args: map[string]CheckArgument{
 			"file":         {value: &c.FilePathPatterns, description: "The file that should be checked"},
 			"files":        {value: &c.FilePathPatternsCS, description: "Comma separated list of files"},
@@ -166,8 +166,11 @@ func (c *CheckLogFile) Check(_ context.Context, snc *Agent, check *CheckData, _
 		"file_counts": c.buildFileCountsDetailString(checkedFilesWithMatchedEntries),
 	}
 
-	if len(check.listData) == 0 {
+	if len(checkedFilesWithMatchedEntries) == 0 {
+		check.okSyntax = "%(status) - No files found to search lines in"
+	} else if len(check.listData) == 0 {
 		check.emptySyntax = fmt.Sprintf("%%(status) - No matching lines found in files (%s)", check.details["file_counts"])
+		check.emptyStateSet = true
 	}
 
 	return check.Finalize()

pkg/snclient/check_logfile_test.go

@@ -121,8 +121,18 @@ func TestCheckLogFileFileExistsButHasNoLines(t *testing.T) {
 	snc := StartTestAgent(t, testLogfileConfig)
 
 	res := snc.RunCheck("check_logfile", []string{"files=./t/test*", "filter=line LIKE this-pattern-does-not-exist-in-the-test-files", "show-all"})
-	assert.Equalf(t, CheckExitUnknown, res.State, "state UNKNOWN")
-	assert.Contains(t, string(res.BuildPluginOutput()), "UNKNOWN - No matching lines found in files ")
+	assert.Equalf(t, CheckExitOK, res.State, "state should be OK")
+	assert.Contains(t, string(res.BuildPluginOutput()), "OK - No matching lines found in files")
+
+	StopTestAgent(t, snc)
+}
+
+func TestCheckLogFileFileDoesNotExist(t *testing.T) {
+	snc := StartTestAgent(t, testLogfileConfig)
+
+	res := snc.RunCheck("check_logfile", []string{"files=./t/testfiledoesnotexist*"})
+	assert.Equalf(t, CheckExitOK, res.State, "state should be OK")
+	assert.Contains(t, string(res.BuildPluginOutput()), "OK - No files found to search lines in")
 
 	StopTestAgent(t, snc)
 }