check_tasksched: misc improvements

add hidden argument to check, this is used while discovering tasks in the embedded powershell script directly.

add debug to stderr calls for the folder,title, recursive and hidden parameters/args in the script

add logic to remove trailing backslash in the folder path, is only removed if its not root path . this is needed due to new script using scheduler.service com tasks

change the working_dir attribute to working_directory to match with existing check definitions

Author: inqrphl

pkg/snclient/check_tasksched.go

@@ -14,19 +14,22 @@ type CheckTasksched struct {
 	TaskTitle string
 	Folder    string
 	Recursive bool
+	Hidden    bool
 }
 
 const (
 	CheckTaskschedDefaultTaskTitle string = "*"
 	CheckTaskschedDefaultFolder    string = "\\"
 	CheckTaskschedDefaultRecursive bool   = true
+	CheckTaskschedDefaultHidden    bool   = false
 )
 
 func NewCheckTasksched() CheckHandler {
 	return &CheckTasksched{
 		TaskTitle: CheckTaskschedDefaultTaskTitle,
 		Folder:    CheckTaskschedDefaultFolder,
 		Recursive: CheckTaskschedDefaultRecursive,
+		Hidden:    CheckTaskschedDefaultHidden,
 	}
 }
 
@@ -43,6 +46,7 @@ func (l *CheckTasksched) Build() *CheckData {
 			"title":     {value: &l.TaskTitle, description: "Sets the task to check. This corresonds to the title of the scheduled task, called TaskName in Powershell output."},
 			"folder":    {value: &l.Folder, description: "The folder where the scheduled task is saved. This is used for exact matches, unless recurisive option is enabled."},
 			"recursive": {value: &l.Recursive, description: "Include the subfolders of the specified folder as well when searching for scheduled tasks."},
+			"hidden":    {value: &l.Hidden, description: "Include hidden tasks."},
 		},
 		defaultFilter:   "enabled = true",
 		defaultCritical: "exit_code < 0",
@@ -73,7 +77,7 @@ func (l *CheckTasksched) Build() *CheckData {
 			{name: "next_run_time", description: "Time when the registered task is next scheduled to run", unit: UDate},
 			{name: "parameters", description: "Last actions command line parameters"},
 			{name: "execute", description: "Last actions executed program"},
-			{name: "working_dir", description: "Last actions working directory"},
+			{name: "working_directory", description: "Last actions working directory"},
 		},
 		exampleDefault: `
     check_tasksched

pkg/snclient/check_tasksched_windows.go

@@ -29,6 +29,14 @@ func (l *CheckTasksched) addTasks(ctx context.Context, snc *Agent, check *CheckD
 		}
 	}
 
+	// Remove backslash at the end of the folder path, if it is not exactly root: "\"
+	// "\Microsoft\" -> "\Microsoft"
+	if l.Folder != CheckTaskschedDefaultFolder && l.Folder != "\\" {
+		if cut, cutOk := strings.CutSuffix(l.Folder, "\\"); cutOk {
+			l.Folder = cut
+		}
+	}
+
 	titleRuneBlacklist := []rune{'\\', '/', ':', '*', '?', '"', '<', '>', '|'}
 	if l.TaskTitle != CheckTaskschedDefaultTaskTitle {
 		if strings.ContainsFunc(l.TaskTitle, func(r rune) bool { return slices.Contains(titleRuneBlacklist, r) }) {
@@ -70,6 +78,14 @@ func (l *CheckTasksched) addTasks(ctx context.Context, snc *Agent, check *CheckD
 			specifyValue:        true,
 			specifiedValue:      strconv.FormatBool(l.Recursive),
 		},
+		PowerShellParameter{
+			name:                "hidden",
+			parameterType:       "string",
+			specifyDefaultValue: true,
+			defaultValue:        strconv.FormatBool(CheckTaskschedDefaultHidden),
+			specifyValue:        true,
+			specifiedValue:      strconv.FormatBool(l.Hidden),
+		},
 	)
 	if err != nil {
 		return fmt.Errorf("error when building a powershell command: %s", err.Error())
@@ -118,7 +134,7 @@ func (l *CheckTasksched) addTasks(ctx context.Context, snc *Agent, check *CheckD
 			"next_run_time":        fmt.Sprintf("%d", l.parseDate(task.NextRunTime).Unix()),
 			"parameters":           l.parseParameters(task.Actions),
 			"execute":              l.parseExecuteCmd(task.Actions),
-			"working_dir":          l.parseWorkingDir(task.Actions),
+			"working_directory":    l.parseWorkingDir(task.Actions),
 		}
 		check.listData = append(check.listData, entry)
 	}

pkg/snclient/embed/scripts/windows/scheduled_tasks.ps1

@@ -24,13 +24,25 @@ if ($args) {
             $i++
             continue
         }
+        if ($args[$i] -eq '-hidden' -and $i + 1 -lt $args.Count) {
+            $hidden = $args[$i + 1]
+            $i++
+            continue
+        }
     }
 }
 
 # Apply defaults when variables are not defined (neither by snclient parameter injection nor by args)
 if (!$title) { $title = '*' }
 if (!$folder) { $folder = '\' }
 if (!$recursive) { $recursive = 'true' }
+if (!$hidden) { $hidden = 'true' }
+
+# debug the parameters/arguments
+[Console]::Error.WriteLine(('title: ' + $title ))
+[Console]::Error.WriteLine(('folder: ' + $folder ))
+[Console]::Error.WriteLine(('recursive: ' + $recursive ))
+[Console]::Error.WriteLine(('hidden: ' + $hidden ))
 
 # ensure output is utf8
 $OutputEncoding = [Console]::OutputEncoding = [Text.UTF8Encoding]::UTF8
@@ -54,7 +66,12 @@ try {
         $currentFolder = $folderQueue.Dequeue()
         # TASK_ENUM_HIDDEN = 1, include hidden tasks
         # Call GetTasks() using TASK_ENUM_HIDDEN
-        foreach ($t in $currentFolder.GetTasks(1)) {
+        if ($hidden -eq 'true'){
+            $getTasksArg = 1
+        } else {
+            $getTasksArg = 0
+        }
+        foreach ($t in $currentFolder.GetTasks($getTasksArg)) {
             $tasks.Add($t)
         }
         if ($recursive -eq 'true') {