Ar/psr 11 oncelock#1620
Merged
allanbrondum merged 12 commits intofeature/rust_block_statefrom Apr 21, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/rust_block_state #1620 +/- ##
============================================================
- Coverage 63.88% 63.87% -0.02%
============================================================
Files 356 356
Lines 71251 71196 -55
Branches 3032 3032
============================================================
- Hits 45519 45474 -45
+ Misses 22700 22690 -10
Partials 3032 3032
|
Base automatically changed from
ar/psr-82-implement-benchmarks-of-rust-lfmb-tree
to
feature/rust_block_state
April 21, 2026 06:36
limemloh
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Replace the usages of
RwLockwithOnceLock, that is a simpler and more lightweight synchronization primitive. Reading the value in aOnceLocke.g. has almost no overhead. And you can borrow the value (no guard needed like forRwLock).Changes
HashedCacheableRefto useOnceLockHashedCacheableRef::with_valuetoHashedCacheableRef::valuethat borrows the valuefrom
HashedCacheableRefis it is memory (no read closure needed).Checklist
hard-to-understand areas.