Use server-side card column filtering

Author: robzolkos

internal/commands/card.go

@@ -57,34 +57,35 @@ var cardListCmd = &cobra.Command{
 			params = append(params, "board_ids[]="+boardID)
 		}
 
-		clientSideColumnFilter := ""
-		clientSideTriage := false
 		if columnFilter != "" {
 			if pseudo, ok := parsePseudoColumnID(columnFilter); ok {
 				switch pseudo.Kind {
 				case "not_now":
 					if effectiveIndexedBy != "" && effectiveIndexedBy != "not_now" {
-						return errors.NewInvalidArgsError("cannot combine --indexed-by with --column maybe")
+						return errors.NewInvalidArgsError("cannot combine --indexed-by with --column " + columnFilter)
 					}
 					effectiveIndexedBy = "not_now"
 				case "closed":
 					if effectiveIndexedBy != "" && effectiveIndexedBy != "closed" {
-						return errors.NewInvalidArgsError("cannot combine --indexed-by with --column done")
+						return errors.NewInvalidArgsError("cannot combine --indexed-by with --column " + columnFilter)
 					}
 					effectiveIndexedBy = "closed"
 				case "triage":
-					if effectiveIndexedBy != "" {
-						return errors.NewInvalidArgsError("cannot combine --indexed-by with --column not-yet")
+					if effectiveIndexedBy != "" && effectiveIndexedBy != "maybe" {
+						return errors.NewInvalidArgsError("cannot combine --indexed-by with --column " + columnFilter)
 					}
-					clientSideTriage = true
+					effectiveIndexedBy = "maybe"
 				default:
-					clientSideColumnFilter = columnFilter
+					if effectiveIndexedBy != "" {
+						return errors.NewInvalidArgsError("cannot combine --indexed-by with --column")
+					}
+					params = append(params, "column_ids[]="+columnFilter)
 				}
 			} else {
 				if effectiveIndexedBy != "" {
 					return errors.NewInvalidArgsError("cannot combine --indexed-by with --column")
 				}
-				clientSideColumnFilter = columnFilter
+				params = append(params, "column_ids[]="+columnFilter)
 			}
 		}
 
@@ -128,10 +129,6 @@ var cardListCmd = &cobra.Command{
 			path += "?" + strings.Join(params, "&")
 		}
 
-		if (clientSideTriage || clientSideColumnFilter != "") && !cardListAll && cardListPage == 0 {
-			return errors.NewInvalidArgsError("Filtering by column requires --all (or --page) because it is applied client-side")
-		}
-
 		var items any
 		var linkNext string
 
@@ -150,46 +147,6 @@ var cardListCmd = &cobra.Command{
 			linkNext = parseSDKLinkNext(resp)
 		}
 
-		if clientSideTriage || clientSideColumnFilter != "" {
-			arr := toSliceAny(items)
-			if arr == nil {
-				return errors.NewError("Unexpected cards list response")
-			}
-
-			filtered := make([]any, 0, len(arr))
-			for _, item := range arr {
-				card, ok := item.(map[string]any)
-				if !ok {
-					continue
-				}
-
-				columnID := ""
-				if v, ok := card["column_id"].(string); ok {
-					columnID = v
-				}
-				if columnID == "" {
-					if col, ok := card["column"].(map[string]any); ok {
-						if id, ok := col["id"].(string); ok {
-							columnID = id
-						}
-					}
-				}
-
-				if clientSideTriage {
-					if columnID == "" {
-						filtered = append(filtered, item)
-					}
-					continue
-				}
-
-				if clientSideColumnFilter != "" && columnID == clientSideColumnFilter {
-					filtered = append(filtered, item)
-				}
-			}
-
-			items = filtered
-		}
-
 		// Build summary
 		count := dataCount(items)
 		summary := fmt.Sprintf("%d cards", count)
@@ -1082,9 +1039,9 @@ func init() {
 
 	// List
 	cardListCmd.Flags().StringVar(&cardListBoard, "board", "", "Filter by board ID")
-	cardListCmd.Flags().StringVar(&cardListColumn, "column", "", "Filter by column ID or pseudo column (not-yet, maybe, done)")
+	cardListCmd.Flags().StringVar(&cardListColumn, "column", "", "Filter by column ID or pseudo column (not-now, maybe, done)")
 	cardListCmd.Flags().StringVar(&cardListTag, "tag", "", "Filter by tag ID")
-	cardListCmd.Flags().StringVar(&cardListIndexedBy, "indexed-by", "", "Filter by lane/index (all, closed, not_now, stalled, postponing_soon, golden)")
+	cardListCmd.Flags().StringVar(&cardListIndexedBy, "indexed-by", "", "Filter by lane/index (all, closed, maybe, not_now, stalled, postponing_soon, golden)")
 	cardListCmd.Flags().StringVar(&cardListIndexedBy, "status", "", "Alias for --indexed-by")
 	_ = cardListCmd.Flags().MarkDeprecated("status", "use --indexed-by")
 	cardListCmd.Flags().StringVar(&cardListAssignee, "assignee", "", "Filter by assignee ID")

internal/commands/card_test.go

@@ -88,29 +88,45 @@ func TestCardList(t *testing.T) {
 		}
 	})
 
-	t.Run("requires --all for client-side triage filter", func(t *testing.T) {
+	t.Run("filters by real column server-side without client-side filtering", func(t *testing.T) {
 		mock := NewMockClient()
-		SetTestModeWithSDK(mock)
+		mock.GetWithPaginationResponse = &client.APIResponse{
+			StatusCode: 200,
+			Data: []any{
+				map[string]any{"id": "1", "title": "Column 1", "column_id": "col-1"},
+				map[string]any{"id": "2", "title": "Column 2", "column_id": "col-2"},
+			},
+		}
+
+		result := SetTestModeWithSDK(mock)
 		SetTestConfig("token", "account", "https://api.example.com")
 		defer resetTest()
 
-		cardListColumn = "maybe"
-		cardListAll = false
-		cardListPage = 0
+		cardListColumn = "col-1"
 		err := cardListCmd.RunE(cardListCmd, []string{})
 		cardListColumn = ""
 
-		assertExitCode(t, err, errors.ExitInvalidArgs)
+		assertExitCode(t, err, 0)
+		if mock.GetWithPaginationCalls[0].Path != "/cards.json?column_ids[]=col-1" {
+			t.Errorf("expected server-side column_ids filter, got '%s'", mock.GetWithPaginationCalls[0].Path)
+		}
+
+		arr, ok := result.Response.Data.([]any)
+		if !ok {
+			t.Fatalf("expected array response data, got %T", result.Response.Data)
+		}
+		if len(arr) != 2 {
+			t.Fatalf("expected server response to remain unfiltered client-side, got %d cards", len(arr))
+		}
 	})
 
-	t.Run("filters triage client-side with --all", func(t *testing.T) {
+	t.Run("filters by pseudo column maybe server-side without all", func(t *testing.T) {
 		mock := NewMockClient()
 		mock.GetWithPaginationResponse = &client.APIResponse{
 			StatusCode: 200,
 			Data: []any{
 				map[string]any{"id": "1", "title": "Triage", "column": nil},
-				map[string]any{"id": "2", "title": "In Column", "column": map[string]any{"id": "col-1"}},
-				map[string]any{"id": "3", "title": "In Column 2", "column_id": "col-2"},
+				map[string]any{"id": "2", "title": "Unexpected extra", "column_id": "col-1"},
 			},
 		}
 
@@ -119,26 +135,20 @@ func TestCardList(t *testing.T) {
 		defer resetTest()
 
 		cardListColumn = "maybe"
-		cardListAll = true
 		err := cardListCmd.RunE(cardListCmd, []string{})
 		cardListColumn = ""
-		cardListAll = false
 
 		assertExitCode(t, err, 0)
-
-		if err != nil {
-			t.Fatalf("unexpected error: %v", err)
+		if mock.GetWithPaginationCalls[0].Path != "/cards.json?indexed_by=maybe" {
+			t.Errorf("expected server-side maybe filter, got '%s'", mock.GetWithPaginationCalls[0].Path)
 		}
+
 		arr, ok := result.Response.Data.([]any)
 		if !ok {
 			t.Fatalf("expected array response data, got %T", result.Response.Data)
 		}
-		if len(arr) != 1 {
-			t.Fatalf("expected 1 triage card, got %d", len(arr))
-		}
-		card := arr[0].(map[string]any)
-		if card["id"] != "1" {
-			t.Errorf("expected triage card id '1', got '%v'", card["id"])
+		if len(arr) != 2 {
+			t.Fatalf("expected server response to remain unfiltered client-side, got %d cards", len(arr))
 		}
 	})
 
@@ -332,6 +342,35 @@ func TestCardList(t *testing.T) {
 			t.Errorf("expected path '%s', got '%s'", expected, path)
 		}
 	})
+
+	t.Run("combines column with other filters without changing command shape", func(t *testing.T) {
+		mock := NewMockClient()
+		mock.GetWithPaginationResponse = &client.APIResponse{
+			StatusCode: 200,
+			Data:       []any{},
+		}
+
+		SetTestModeWithSDK(mock)
+		SetTestConfig("token", "account", "https://api.example.com")
+		defer resetTest()
+
+		cardListBoard = "123"
+		cardListColumn = "col-1"
+		cardListTag = "tag-1"
+		cardListAssignee = "user-1"
+		err := cardListCmd.RunE(cardListCmd, []string{})
+		cardListBoard = ""
+		cardListColumn = ""
+		cardListTag = ""
+		cardListAssignee = ""
+
+		assertExitCode(t, err, 0)
+		path := mock.GetWithPaginationCalls[0].Path
+		expected := "/cards.json?board_ids[]=123&column_ids[]=col-1&tag_ids[]=tag-1&assignee_ids[]=user-1"
+		if path != expected {
+			t.Errorf("expected path '%s', got '%s'", expected, path)
+		}
+	})
 }
 
 func TestCardShow(t *testing.T) {

internal/commands/pseudocolumns.go

@@ -11,9 +11,10 @@ type pseudoColumn struct {
 var (
 	// "Not Now" contains postponed cards (indexed_by=not_now)
 	pseudoColumnNotNow = pseudoColumn{ID: "not-now", Name: "Not Now", Kind: "not_now"}
-	// "Maybe?" contains triage/backlog cards (null column_id)
+	// "Maybe?" contains triage/backlog cards (indexed_by=maybe)
 	pseudoColumnMaybe = pseudoColumn{ID: "maybe", Name: "Maybe?", Kind: "triage"}
-	pseudoColumnDone  = pseudoColumn{ID: "done", Name: "Done", Kind: "closed"}
+	// "Done" contains closed cards (indexed_by=closed)
+	pseudoColumnDone = pseudoColumn{ID: "done", Name: "Done", Kind: "closed"}
 )
 
 func pseudoColumnObject(c pseudoColumn) map[string]any {

internal/commands/search.go

@@ -112,7 +112,7 @@ func init() {
 	searchCmd.Flags().StringVar(&searchBoard, "board", "", "Filter by board ID")
 	searchCmd.Flags().StringVar(&searchTag, "tag", "", "Filter by tag ID")
 	searchCmd.Flags().StringVar(&searchAssignee, "assignee", "", "Filter by assignee ID")
-	searchCmd.Flags().StringVar(&searchIndexedBy, "indexed-by", "", "Filter by status (all, closed, not_now, golden)")
+	searchCmd.Flags().StringVar(&searchIndexedBy, "indexed-by", "", "Filter by status (all, closed, maybe, not_now, golden)")
 	searchCmd.Flags().StringVar(&searchSort, "sort", "", "Sort order: newest, oldest, or latest (default)")
 	searchCmd.Flags().IntVar(&searchPage, "page", 0, "Page number")
 	searchCmd.Flags().BoolVar(&searchAll, "all", false, "Fetch all pages")

skills/fizzy/SKILL.md

@@ -77,7 +77,7 @@ Full CLI coverage: boards, cards, columns, comments, steps, reactions, tags, use
 Need to find something?
 ├── Know the board? → fizzy card list --board <id>
 ├── Full-text search? → fizzy search "query"
-├── Filter by status? → fizzy card list --indexed-by closed|not_now|golden|stalled
+├── Filter by status? → fizzy card list --indexed-by maybe|closed|not_now|golden|stalled
 ├── Filter by person? → fizzy card list --assignee <id>
 ├── Filter by time? → fizzy card list --created today|thisweek|thismonth
 └── Cross-board? → fizzy search "query" (searches all boards)
@@ -360,9 +360,9 @@ Cards exist in different states. By default, `fizzy card list` returns **open ca
 You can also use pseudo-columns:
 
 ```bash
-fizzy card list --column done --all     # Same as --indexed-by closed
-fizzy card list --column not-now --all  # Same as --indexed-by not_now
-fizzy card list --column maybe --all    # Cards in triage (no column assigned)
+fizzy card list --column done      # Same as --indexed-by closed
+fizzy card list --column not-now   # Same as --indexed-by not_now
+fizzy card list --column maybe     # Same as --indexed-by maybe
 ```
 
 **Fetching all cards on a board:**
@@ -475,7 +475,7 @@ fizzy search QUERY [flags]
   --board ID                           # Filter by board
   --assignee ID                        # Filter by assignee user ID
   --tag ID                             # Filter by tag ID
-  --indexed-by LANE                    # Filter: all, closed, not_now, golden
+  --indexed-by LANE                    # Filter: all, closed, maybe, not_now, golden
   --sort ORDER                         # Sort: newest, oldest, or latest (default)
   --page N                             # Page number
   --all                                # Fetch all pages
@@ -559,7 +559,7 @@ fizzy card list [flags]
   --column ID                          # Filter by column ID or pseudo: not-now, maybe, done
   --assignee ID                        # Filter by assignee user ID
   --tag ID                             # Filter by tag ID
-  --indexed-by LANE                    # Filter: all, closed, not_now, stalled, postponing_soon, golden
+  --indexed-by LANE                    # Filter: all, closed, maybe, not_now, stalled, postponing_soon, golden
   --search "terms"                     # Search by text (space-separated for multiple terms)
   --sort ORDER                         # Sort: newest, oldest, or latest (default)
   --creator ID                         # Filter by creator user ID