Address PR review feedback on e2e harness

Author: robzolkos

.gitignore

@@ -32,3 +32,6 @@ completions/
 # Profiling
 profiles/
 default.pgo
+
+# Local test credentials
+.env.test

Makefile

@@ -5,7 +5,10 @@
 
 BINARY := $(CURDIR)/bin/fizzy
 
-# Load local test credentials if present (file is git-excluded via .git/info/exclude).
+# Load local test credentials if present, but refuse tracked local secret files.
+ifneq ($(shell git ls-files --error-unmatch .env.test >/dev/null 2>&1 && echo tracked),)
+$(error .env.test is tracked by Git. Remove it from version control and keep local secret files untracked)
+endif
 -include .env.test
 export FIZZY_TEST_TOKEN FIZZY_TEST_ACCOUNT FIZZY_TEST_API_URL
 VERSION ?= $(shell git describe --tags --always --dirty 2>/dev/null || echo dev)

e2e/cli_tests/helpers_test.go

@@ -306,14 +306,14 @@ func avatarRedirects(t *testing.T, avatarURL string) bool {
 			t.Fatalf("fetch avatar headers: %v", err)
 		}
 		resp.Body.Close()
-		switch resp.StatusCode {
-		case http.StatusFound:
-			return true
-		case http.StatusOK:
+		switch {
+		case resp.StatusCode == http.StatusOK:
 			return false
+		case resp.StatusCode/100 == 3:
+			return true
 		}
 		time.Sleep(200 * time.Millisecond)
 	}
-	t.Fatalf("avatar endpoint %s did not settle on 200 or 302", avatarURL)
+	t.Fatalf("avatar endpoint %s did not settle on 200 or 3xx", avatarURL)
 	return false
 }

e2e/cli_tests/search_and_auth_test.go

@@ -17,12 +17,12 @@ func TestAuthInvalidToken(t *testing.T) {
 	badCfg := *cfg
 	badCfg.Token = "fizzy_invalid_token"
 	h := harness.NewWithConfig(t, &badCfg)
-	assertResult(t, h.Run("board", "list"), harness.ExitAuth)
+	assertResult(t, h.Run("board", "list"), harness.ExitAuthFailure)
 }
 
 func TestAuthMissingToken(t *testing.T) {
 	missingCfg := *cfg
 	missingCfg.Token = ""
 	h := harness.NewWithConfig(t, &missingCfg)
-	assertResult(t, h.Run("board", "list"), harness.ExitAuth)
+	assertResult(t, h.Run("board", "list"), harness.ExitAuthFailure)
 }

e2e/harness/fixture.go

@@ -51,13 +51,14 @@ func NewSharedFixture(cfg *Config) (*SharedFixture, error) {
 // Teardown removes all fixture resources. Deleting the board cascades to all
 // child resources (cards, columns, comments, steps, reactions).
 func (f *SharedFixture) Teardown() error {
-	defer os.RemoveAll(f.configHome)
-	if f.BoardID == "" {
-		return nil
-	}
-	r := f.run("board", "delete", f.BoardID)
-	if r.ExitCode != ExitSuccess && r.ExitCode != ExitNotFound {
-		return fmt.Errorf("delete fixture board %s: exit %d\nstderr: %s", f.BoardID, r.ExitCode, r.Stderr)
+	if f.BoardID != "" {
+		r := f.run("board", "delete", f.BoardID)
+		if r.ExitCode != ExitSuccess && r.ExitCode != ExitNotFound {
+			return fmt.Errorf("delete fixture board %s: exit %d\nstderr: %s", f.BoardID, r.ExitCode, r.Stderr)
+		}
+	}
+	if err := os.RemoveAll(f.configHome); err != nil {
+		return fmt.Errorf("remove fixture config home %s: %w", f.configHome, err)
 	}
 	return nil
 }