Add explicit return after t.Fatal in agent test

robzolkos · robzolkos · commit 8e7fb982b495 · 2026-04-30T09:14:59.000-04:00
golangci-lint v2.10.1 (used in CI) trips SA5011 on this pattern even though t.Fatal halts — newer staticcheck versions handle it correctly. Adding the explicit return is harmless and unblocks the lint check.
diff --git a/internal/harness/agent_test.go b/internal/harness/agent_test.go
@@ -16,6 +16,7 @@ func TestRegisterAgent(t *testing.T) {
 		agent := FindAgent("test")
 		if agent == nil {
 			t.Fatal("expected to find registered agent")
+			return
 		}
 		if agent.Name != "Test Agent" {
 			t.Errorf("expected name 'Test Agent', got %q", agent.Name)

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@ func TestRegisterAgent(t *testing.T) {`
`16`	`16`	`agent := FindAgent("test")`
`17`	`17`	`if agent == nil {`
`18`	`18`	`t.Fatal("expected to find registered agent")`
	`19`	`+ return`
`19`	`20`	`}`
`20`	`21`	`if agent.Name != "Test Agent" {`
`21`	`22`	`t.Errorf("expected name 'Test Agent', got %q", agent.Name)`