Skip to content

Commit 0886a86

Browse files
committed
Refactor RouteImport interface: rename route() method to getRoute() and update EnumLoader usage
1 parent 292eef8 commit 0886a86

4 files changed

Lines changed: 24 additions & 13 deletions

File tree

src/main/java/fr/sandro642/github/example/ExampleUsages.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import fr.sandro642.github.enums.MethodType;
77
import fr.sandro642.github.enums.ResourceType;
88
import fr.sandro642.github.enums.VersionType;
9+
import fr.sandro642.github.jobs.RouteImport;
910
import fr.sandro642.github.misc.EnumLoader;
1011

1112
import java.util.Map;
@@ -25,7 +26,7 @@ public class ExampleUsages {
2526

2627
private ConnectLib connectLib = new ConnectLib();
2728

28-
public enum ExampleRoutes implements EnumLoader.RouteImport {
29+
public enum ExampleRoutes implements RouteImport {
2930
EXAMPLE_ROUTE("/api/example/route");
3031

3132
final String route;
@@ -35,7 +36,7 @@ public enum ExampleRoutes implements EnumLoader.RouteImport {
3536
}
3637

3738
@Override
38-
public String route() {
39+
public String getRoute() {
3940
return route;
4041
}
4142
}
Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
1+
package fr.sandro642.github.jobs;
2+
3+
/**
4+
* RouteImport is an interface that should be implemented by enums that provide a route.
5+
* Enums implementing this interface must define the route() method to return their associated route as a String.
6+
*/
7+
8+
public interface RouteImport {
9+
10+
/**
11+
* Gets the route associated with the enum constant.
12+
* @return the route as a String
13+
*/
14+
String getRoute();
15+
}

src/main/java/fr/sandro642/github/misc/EnumLoader.java

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
package fr.sandro642.github.misc;
22

3+
import fr.sandro642.github.jobs.RouteImport;
4+
35
import java.util.HashMap;
46
import java.util.Map;
57

@@ -13,14 +15,6 @@
1315

1416
public class EnumLoader {
1517

16-
/**
17-
* RouteImport is an interface that should be implemented by enums that provide a route.
18-
* Enums implementing this interface must define the route() method to return their associated route as a String.
19-
*/
20-
public interface RouteImport {
21-
String route();
22-
}
23-
2418
/**
2519
* Converts an enum class that implements RouteImport into a map.
2620
* The keys of the map are the enum constants, and the values are their corresponding routes.
@@ -33,7 +27,7 @@ public static Map<Enum<?>, String> convertRouteImport(Class<? extends Enum<?>> e
3327
HashMap<Enum<?>, String> map = new HashMap<>();
3428
for (Enum<?> e : enums) {
3529
if (e instanceof RouteImport routeImport) {
36-
map.put((Enum<?>) routeImport, routeImport.route());
30+
map.put((Enum<?>) routeImport, routeImport.getRoute());
3731
}
3832
}
3933
return map;

src/test/java/fr/sandro642/github/test/MainTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import fr.sandro642.github.enums.LangType;
77
import fr.sandro642.github.enums.MethodType;
88
import fr.sandro642.github.enums.ResourceType;
9+
import fr.sandro642.github.jobs.RouteImport;
910
import fr.sandro642.github.jobs.VersionProvider;
1011
import fr.sandro642.github.misc.EnumLoader;
1112
import org.junit.jupiter.api.Test;
@@ -25,7 +26,7 @@ public class MainTest {
2526

2627
private static ConnectLib connectLib = new ConnectLib();
2728

28-
public enum TestRoutes implements EnumLoader.RouteImport {
29+
public enum TestRoutes implements RouteImport {
2930
HELLO("/hello"),
3031
GREET("/greet$name$")
3132
;
@@ -37,7 +38,7 @@ public enum TestRoutes implements EnumLoader.RouteImport {
3738
}
3839

3940
@Override
40-
public String route() {
41+
public String getRoute() {
4142
return route;
4243
}
4344
}

0 commit comments

Comments
 (0)