Skip to content

Commit 78c9c90

Browse files
authored
Revert "Fix consistency issues in security monitoring signal triage routes (#…" (DataDog#3884)
This reverts commit 76fd9e5.
1 parent 76fd9e5 commit 78c9c90

3 files changed

Lines changed: 46 additions & 28 deletions

File tree

.generator/schemas/v2/openapi.yaml

Lines changed: 45 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -57909,7 +57909,6 @@ components:
5790957909
- none
5791057910
- false_positive
5791157911
- testing_or_maintenance
57912-
- remediated
5791357912
- investigated_case_opened
5791457913
- true_positive_benign
5791557914
- true_positive_malicious
@@ -57919,7 +57918,6 @@ components:
5791957918
- NONE
5792057919
- FALSE_POSITIVE
5792157920
- TESTING_OR_MAINTENANCE
57922-
- REMEDIATED
5792357921
- INVESTIGATED_CASE_OPENED
5792457922
- TRUE_POSITIVE_BENIGN
5792557923
- TRUE_POSITIVE_MALICIOUS
@@ -102449,8 +102447,6 @@ paths:
102449102447
schema:
102450102448
$ref: "#/components/schemas/SecurityMonitoringSignalResponse"
102451102449
description: OK
102452-
"403":
102453-
$ref: "#/components/responses/NotAuthorizedResponse"
102454102450
"404":
102455102451
$ref: "#/components/responses/NotFoundResponse"
102456102452
"429":
@@ -102488,17 +102484,25 @@ paths:
102488102484
$ref: "#/components/schemas/SecurityMonitoringSignalTriageUpdateResponse"
102489102485
description: OK
102490102486
"400":
102491-
$ref: "#/components/responses/BadRequestResponse"
102487+
content:
102488+
application/json:
102489+
schema:
102490+
$ref: "#/components/schemas/APIErrorResponse"
102491+
description: Bad Request
102492102492
"403":
102493-
$ref: "#/components/responses/NotAuthorizedResponse"
102493+
content:
102494+
application/json:
102495+
schema:
102496+
$ref: "#/components/schemas/APIErrorResponse"
102497+
description: Forbidden
102494102498
"404":
102495-
$ref: "#/components/responses/NotFoundResponse"
102499+
content:
102500+
application/json:
102501+
schema:
102502+
$ref: "#/components/schemas/APIErrorResponse"
102503+
description: Not Found
102496102504
"429":
102497102505
$ref: "#/components/responses/TooManyRequestsResponse"
102498-
security:
102499-
- apiKeyAuth: []
102500-
appKeyAuth: []
102501-
- AuthZ: []
102502102506
summary: Modify the triage assignee of a security signal
102503102507
tags: ["Security Monitoring"]
102504102508
x-codegen-request-body-name: body
@@ -102528,17 +102532,25 @@ paths:
102528102532
$ref: "#/components/schemas/SecurityMonitoringSignalTriageUpdateResponse"
102529102533
description: OK
102530102534
"400":
102531-
$ref: "#/components/responses/BadRequestResponse"
102535+
content:
102536+
application/json:
102537+
schema:
102538+
$ref: "#/components/schemas/APIErrorResponse"
102539+
description: Bad Request
102532102540
"403":
102533-
$ref: "#/components/responses/NotAuthorizedResponse"
102541+
content:
102542+
application/json:
102543+
schema:
102544+
$ref: "#/components/schemas/APIErrorResponse"
102545+
description: Forbidden
102534102546
"404":
102535-
$ref: "#/components/responses/NotFoundResponse"
102547+
content:
102548+
application/json:
102549+
schema:
102550+
$ref: "#/components/schemas/APIErrorResponse"
102551+
description: Not Found
102536102552
"429":
102537102553
$ref: "#/components/responses/TooManyRequestsResponse"
102538-
security:
102539-
- apiKeyAuth: []
102540-
appKeyAuth: []
102541-
- AuthZ: []
102542102554
summary: Change the related incidents of a security signal
102543102555
tags: ["Security Monitoring"]
102544102556
x-codegen-request-body-name: body
@@ -102568,17 +102580,25 @@ paths:
102568102580
$ref: "#/components/schemas/SecurityMonitoringSignalTriageUpdateResponse"
102569102581
description: OK
102570102582
"400":
102571-
$ref: "#/components/responses/BadRequestResponse"
102583+
content:
102584+
application/json:
102585+
schema:
102586+
$ref: "#/components/schemas/APIErrorResponse"
102587+
description: Bad Request
102572102588
"403":
102573-
$ref: "#/components/responses/NotAuthorizedResponse"
102589+
content:
102590+
application/json:
102591+
schema:
102592+
$ref: "#/components/schemas/APIErrorResponse"
102593+
description: Forbidden
102574102594
"404":
102575-
$ref: "#/components/responses/NotFoundResponse"
102595+
content:
102596+
application/json:
102597+
schema:
102598+
$ref: "#/components/schemas/APIErrorResponse"
102599+
description: Not Found
102576102600
"429":
102577102601
$ref: "#/components/responses/TooManyRequestsResponse"
102578-
security:
102579-
- apiKeyAuth: []
102580-
appKeyAuth: []
102581-
- AuthZ: []
102582102602
summary: Change the triage state of a security signal
102583102603
tags: ["Security Monitoring"]
102584102604
x-codegen-request-body-name: body

api/datadogV2/api_security_monitoring.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3736,7 +3736,7 @@ func (a *SecurityMonitoringApi) GetSecurityMonitoringSignal(ctx _context.Context
37363736
ErrorBody: localVarBody,
37373737
ErrorMessage: localVarHTTPResponse.Status,
37383738
}
3739-
if localVarHTTPResponse.StatusCode == 403 || localVarHTTPResponse.StatusCode == 404 || localVarHTTPResponse.StatusCode == 429 {
3739+
if localVarHTTPResponse.StatusCode == 404 || localVarHTTPResponse.StatusCode == 429 {
37403740
var v APIErrorResponse
37413741
err = a.Client.Decode(&v, localVarBody, localVarHTTPResponse.Header.Get("Content-Type"))
37423742
if err != nil {

api/datadogV2/model_security_monitoring_signal_archive_reason.go

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ const (
1818
SECURITYMONITORINGSIGNALARCHIVEREASON_NONE SecurityMonitoringSignalArchiveReason = "none"
1919
SECURITYMONITORINGSIGNALARCHIVEREASON_FALSE_POSITIVE SecurityMonitoringSignalArchiveReason = "false_positive"
2020
SECURITYMONITORINGSIGNALARCHIVEREASON_TESTING_OR_MAINTENANCE SecurityMonitoringSignalArchiveReason = "testing_or_maintenance"
21-
SECURITYMONITORINGSIGNALARCHIVEREASON_REMEDIATED SecurityMonitoringSignalArchiveReason = "remediated"
2221
SECURITYMONITORINGSIGNALARCHIVEREASON_INVESTIGATED_CASE_OPENED SecurityMonitoringSignalArchiveReason = "investigated_case_opened"
2322
SECURITYMONITORINGSIGNALARCHIVEREASON_TRUE_POSITIVE_BENIGN SecurityMonitoringSignalArchiveReason = "true_positive_benign"
2423
SECURITYMONITORINGSIGNALARCHIVEREASON_TRUE_POSITIVE_MALICIOUS SecurityMonitoringSignalArchiveReason = "true_positive_malicious"
@@ -29,7 +28,6 @@ var allowedSecurityMonitoringSignalArchiveReasonEnumValues = []SecurityMonitorin
2928
SECURITYMONITORINGSIGNALARCHIVEREASON_NONE,
3029
SECURITYMONITORINGSIGNALARCHIVEREASON_FALSE_POSITIVE,
3130
SECURITYMONITORINGSIGNALARCHIVEREASON_TESTING_OR_MAINTENANCE,
32-
SECURITYMONITORINGSIGNALARCHIVEREASON_REMEDIATED,
3331
SECURITYMONITORINGSIGNALARCHIVEREASON_INVESTIGATED_CASE_OPENED,
3432
SECURITYMONITORINGSIGNALARCHIVEREASON_TRUE_POSITIVE_BENIGN,
3533
SECURITYMONITORINGSIGNALARCHIVEREASON_TRUE_POSITIVE_MALICIOUS,

0 commit comments

Comments
 (0)