Skip to content

Commit 8af659a

Browse files
api-clients-generation-pipeline[bot]ci.datadog-api-spec
andauthored
Security Monitoring - Fix payload of Validation Endpoint for Suppressions (DataDog#3327)
Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com>
1 parent 675bed7 commit 8af659a

6 files changed

Lines changed: 12 additions & 13 deletions

File tree

.generator/schemas/v2/openapi.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64883,7 +64883,7 @@ paths:
6488364883
content:
6488464884
application/json:
6488564885
schema:
64886-
$ref: '#/components/schemas/SecurityMonitoringSuppressionUpdateRequest'
64886+
$ref: '#/components/schemas/SecurityMonitoringSuppressionCreateRequest'
6488764887
required: true
6488864888
responses:
6488964889
'204':

api/datadogV2/api_security_monitoring.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6807,7 +6807,7 @@ func (a *SecurityMonitoringApi) ValidateSecurityMonitoringRule(ctx _context.Cont
68076807

68086808
// ValidateSecurityMonitoringSuppression Validate a suppression rule.
68096809
// Validate a suppression rule.
6810-
func (a *SecurityMonitoringApi) ValidateSecurityMonitoringSuppression(ctx _context.Context, body SecurityMonitoringSuppressionUpdateRequest) (*_nethttp.Response, error) {
6810+
func (a *SecurityMonitoringApi) ValidateSecurityMonitoringSuppression(ctx _context.Context, body SecurityMonitoringSuppressionCreateRequest) (*_nethttp.Response, error) {
68116811
var (
68126812
localVarHTTPMethod = _nethttp.MethodPost
68136813
localVarPostBody interface{}

examples/v2/security-monitoring/ValidateSecurityMonitoringSuppression.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,14 +12,14 @@ import (
1212
)
1313

1414
func main() {
15-
body := datadogV2.SecurityMonitoringSuppressionUpdateRequest{
16-
Data: datadogV2.SecurityMonitoringSuppressionUpdateData{
17-
Attributes: datadogV2.SecurityMonitoringSuppressionUpdateAttributes{
15+
body := datadogV2.SecurityMonitoringSuppressionCreateRequest{
16+
Data: datadogV2.SecurityMonitoringSuppressionCreateData{
17+
Attributes: datadogV2.SecurityMonitoringSuppressionCreateAttributes{
1818
DataExclusionQuery: datadog.PtrString("source:cloudtrail account_id:12345"),
1919
Description: datadog.PtrString("This rule suppresses low-severity signals in staging environments."),
20-
Enabled: datadog.PtrBool(true),
21-
Name: datadog.PtrString("Custom suppression"),
22-
RuleQuery: datadog.PtrString("type:log_detection source:cloudtrail"),
20+
Enabled: true,
21+
Name: "Custom suppression",
22+
RuleQuery: "type:log_detection source:cloudtrail",
2323
},
2424
Type: datadogV2.SECURITYMONITORINGSUPPRESSIONTYPE_SUPPRESSIONS,
2525
},
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
2025-09-01T21:36:42.334Z
1+
2025-09-04T08:33:38.344Z

tests/scenarios/cassettes/TestScenarios/v2/Feature_Security_Monitoring/Scenario_Validate_a_suppression_rule_returns_Bad_Request_response.yaml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
interactions:
22
- request:
33
body: |
4-
{"data":{"attributes":{"data_exclusion_query":"not enough attributes"},"type":"suppressions"}}
4+
{"data":{"attributes":{"data_exclusion_query":"not enough attributes","enabled":false,"name":"cold_harbour","rule_query":"rule:[A-Invalid"},"type":"suppressions"}}
55
form: {}
66
headers:
77
Accept:
@@ -13,8 +13,7 @@ interactions:
1313
url: https://api.datadoghq.com/api/v2/security_monitoring/configuration/suppressions/validation
1414
response:
1515
body: '{"errors":["input_validation_error(Field ''data.attributes.rule_query''
16-
is invalid: field ''rule_query'' is required)","input_validation_error(Field
17-
''data.attributes.name'' is invalid: name cannot be empty)"]}'
16+
is invalid: rule query is invalid)"]}'
1817
code: 400
1918
duration: 0ms
2019
headers:

tests/scenarios/features/v2/security_monitoring.feature

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1486,7 +1486,7 @@ Feature: Security Monitoring
14861486
@team:DataDog/k9-cloud-security-platform
14871487
Scenario: Validate a suppression rule returns "Bad Request" response
14881488
Given new "ValidateSecurityMonitoringSuppression" request
1489-
And body with value {"data": {"attributes": {"data_exclusion_query": "not enough attributes"}, "type": "suppressions"}}
1489+
And body with value {"data": {"attributes": {"name" : "cold_harbour", "enabled": false, "rule_query":"rule:[A-Invalid", "data_exclusion_query": "not enough attributes"}, "type": "suppressions"}}
14901490
When the request is sent
14911491
Then the response status is 400 Bad Request
14921492

0 commit comments

Comments
 (0)