Skip to content

Commit b5b3862

Browse files
api-clients-generation-pipeline[bot]ci.datadog-api-spec
andauthored
remove duplicate sync_enabled field for PATCH Reference Tables request schema (DataDog#3478)
Co-authored-by: ci.datadog-api-spec <packages@datadoghq.com>
1 parent 4829585 commit b5b3862

4 files changed

Lines changed: 3 additions & 44 deletions

File tree

.generator/schemas/v2/openapi.yaml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40664,7 +40664,6 @@ components:
4066440664
type: STRING
4066540665
primary_keys:
4066640666
- id
40667-
sync_enabled: false
4066840667
tags:
4066940668
- test_tag
4067040669
type: reference_table
@@ -40696,10 +40695,6 @@ components:
4069640695
$ref: '#/components/schemas/PatchTableRequestDataAttributesFileMetadata'
4069740696
schema:
4069840697
$ref: '#/components/schemas/PatchTableRequestDataAttributesSchema'
40699-
sync_enabled:
40700-
description: Whether this table is synced automatically.
40701-
example: false
40702-
type: boolean
4070340698
tags:
4070440699
description: Tags for organizing and filtering reference tables.
4070540700
example:

api/datadogV2/model_patch_table_request_data_attributes.go

Lines changed: 1 addition & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ type PatchTableRequestDataAttributes struct {
1616
FileMetadata *PatchTableRequestDataAttributesFileMetadata `json:"file_metadata,omitempty"`
1717
// Schema defining the updates to the structure and columns of the reference table. Schema fields cannot be deleted or renamed.
1818
Schema *PatchTableRequestDataAttributesSchema `json:"schema,omitempty"`
19-
// Whether this table is synced automatically.
20-
SyncEnabled *bool `json:"sync_enabled,omitempty"`
2119
// Tags for organizing and filtering reference tables.
2220
Tags []string `json:"tags,omitempty"`
2321
// UnparsedObject contains the raw value of the object if there was an error when deserializing into the struct
@@ -126,34 +124,6 @@ func (o *PatchTableRequestDataAttributes) SetSchema(v PatchTableRequestDataAttri
126124
o.Schema = &v
127125
}
128126

129-
// GetSyncEnabled returns the SyncEnabled field value if set, zero value otherwise.
130-
func (o *PatchTableRequestDataAttributes) GetSyncEnabled() bool {
131-
if o == nil || o.SyncEnabled == nil {
132-
var ret bool
133-
return ret
134-
}
135-
return *o.SyncEnabled
136-
}
137-
138-
// GetSyncEnabledOk returns a tuple with the SyncEnabled field value if set, nil otherwise
139-
// and a boolean to check if the value has been set.
140-
func (o *PatchTableRequestDataAttributes) GetSyncEnabledOk() (*bool, bool) {
141-
if o == nil || o.SyncEnabled == nil {
142-
return nil, false
143-
}
144-
return o.SyncEnabled, true
145-
}
146-
147-
// HasSyncEnabled returns a boolean if a field has been set.
148-
func (o *PatchTableRequestDataAttributes) HasSyncEnabled() bool {
149-
return o != nil && o.SyncEnabled != nil
150-
}
151-
152-
// SetSyncEnabled gets a reference to the given bool and assigns it to the SyncEnabled field.
153-
func (o *PatchTableRequestDataAttributes) SetSyncEnabled(v bool) {
154-
o.SyncEnabled = &v
155-
}
156-
157127
// GetTags returns the Tags field value if set, zero value otherwise.
158128
func (o *PatchTableRequestDataAttributes) GetTags() []string {
159129
if o == nil || o.Tags == nil {
@@ -197,9 +167,6 @@ func (o PatchTableRequestDataAttributes) MarshalJSON() ([]byte, error) {
197167
if o.Schema != nil {
198168
toSerialize["schema"] = o.Schema
199169
}
200-
if o.SyncEnabled != nil {
201-
toSerialize["sync_enabled"] = o.SyncEnabled
202-
}
203170
if o.Tags != nil {
204171
toSerialize["tags"] = o.Tags
205172
}
@@ -216,15 +183,14 @@ func (o *PatchTableRequestDataAttributes) UnmarshalJSON(bytes []byte) (err error
216183
Description *string `json:"description,omitempty"`
217184
FileMetadata *PatchTableRequestDataAttributesFileMetadata `json:"file_metadata,omitempty"`
218185
Schema *PatchTableRequestDataAttributesSchema `json:"schema,omitempty"`
219-
SyncEnabled *bool `json:"sync_enabled,omitempty"`
220186
Tags []string `json:"tags,omitempty"`
221187
}{}
222188
if err = datadog.Unmarshal(bytes, &all); err != nil {
223189
return datadog.Unmarshal(bytes, &o.UnparsedObject)
224190
}
225191
additionalProperties := make(map[string]interface{})
226192
if err = datadog.Unmarshal(bytes, &additionalProperties); err == nil {
227-
datadog.DeleteKeys(additionalProperties, &[]string{"description", "file_metadata", "schema", "sync_enabled", "tags"})
193+
datadog.DeleteKeys(additionalProperties, &[]string{"description", "file_metadata", "schema", "tags"})
228194
} else {
229195
return err
230196
}
@@ -236,7 +202,6 @@ func (o *PatchTableRequestDataAttributes) UnmarshalJSON(bytes []byte) (err error
236202
hasInvalidField = true
237203
}
238204
o.Schema = all.Schema
239-
o.SyncEnabled = all.SyncEnabled
240205
o.Tags = all.Tags
241206

242207
if len(additionalProperties) > 0 {

examples/v2/reference-tables/UpdateReferenceTable.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ func main() {
4242
"id",
4343
},
4444
},
45-
SyncEnabled: datadog.PtrBool(false),
4645
Tags: []string{
4746
"test_tag",
4847
},

tests/scenarios/features/v2/reference_tables.feature

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -132,15 +132,15 @@ Feature: Reference Tables
132132
Scenario: Update reference table returns "Bad Request" response
133133
Given new "UpdateReferenceTable" request
134134
And request contains "id" parameter from "REPLACE.ME"
135-
And body with value {"data": {"attributes": {"description": "this is a cloud table generated via a cloud bucket sync", "file_metadata": {"access_details": {"aws_detail": {"aws_account_id": "test-account-id", "aws_bucket_name": "test-bucket", "file_path": "test_rt.csv"}}, "sync_enabled": true}, "schema": {"fields": [{"name": "id", "type": "INT32"}, {"name": "name", "type": "STRING"}], "primary_keys": ["id"]}, "sync_enabled": false, "tags": ["test_tag"]}, "type": "reference_table"}}
135+
And body with value {"data": {"attributes": {"description": "this is a cloud table generated via a cloud bucket sync", "file_metadata": {"access_details": {"aws_detail": {"aws_account_id": "test-account-id", "aws_bucket_name": "test-bucket", "file_path": "test_rt.csv"}}, "sync_enabled": true}, "schema": {"fields": [{"name": "id", "type": "INT32"}, {"name": "name", "type": "STRING"}], "primary_keys": ["id"]}, "tags": ["test_tag"]}, "type": "reference_table"}}
136136
When the request is sent
137137
Then the response status is 400 Bad Request
138138

139139
@generated @skip @team:DataDog/redapl-experiences
140140
Scenario: Update reference table returns "OK" response
141141
Given new "UpdateReferenceTable" request
142142
And request contains "id" parameter from "REPLACE.ME"
143-
And body with value {"data": {"attributes": {"description": "this is a cloud table generated via a cloud bucket sync", "file_metadata": {"access_details": {"aws_detail": {"aws_account_id": "test-account-id", "aws_bucket_name": "test-bucket", "file_path": "test_rt.csv"}}, "sync_enabled": true}, "schema": {"fields": [{"name": "id", "type": "INT32"}, {"name": "name", "type": "STRING"}], "primary_keys": ["id"]}, "sync_enabled": false, "tags": ["test_tag"]}, "type": "reference_table"}}
143+
And body with value {"data": {"attributes": {"description": "this is a cloud table generated via a cloud bucket sync", "file_metadata": {"access_details": {"aws_detail": {"aws_account_id": "test-account-id", "aws_bucket_name": "test-bucket", "file_path": "test_rt.csv"}}, "sync_enabled": true}, "schema": {"fields": [{"name": "id", "type": "INT32"}, {"name": "name", "type": "STRING"}], "primary_keys": ["id"]}, "tags": ["test_tag"]}, "type": "reference_table"}}
144144
When the request is sent
145145
Then the response status is 200 OK
146146

0 commit comments

Comments
 (0)