Commit 1b8d109
authored
Use default instead of display_default for clickhouse password (DataDog#23459)
### What does this PR do?
Switch the clickhouse `password` field in `spec.yaml` from `display_default: ''` to `default: ''`, so the empty-string default is declared through the proper `default` key rather than relying on `display_default` to implicitly drive the generated `instance_password()` default.
### Motivation
PR DataDog#23015 fixed a regression where `password` ended up as `None` at runtime (sending `"default:None"` as credentials) by making the config model generator emit `instance_password()` returning `''`. That default currently comes from `display_default: ''`, which is a side effect of how the default system happens to work rather than an explicit declaration. This change makes the intent explicit: `default: ''` is the source of truth for the runtime default, and `display_default` goes back to being purely a documentation concern.
Generated config models and `conf.yaml.example` are unchanged, so behavior is identical; this is just a correctness cleanup of the spec.
### Review checklist (to be filled by reviewers)
- [ ] Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
- [x] Add the `qa/skip-qa` label if the PR doesn't need to be tested during QA.
- [ ] If you need to backport this PR to another branch, you can add the `backport/<branch-name>` label to the PR and it will automatically open a backport PR once this one is merged1 parent 0c9882f commit 1b8d109
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
44 | | - | |
| 44 | + | |
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
| |||
0 commit comments