Add new metric for application sync duration (DataDog#21882)

* add new metric from argocd

* changelog

* e2e exclude metric

Author: steveny91

argocd/changelog.d/21882.added

@@ -0,0 +1 @@
+Add a new metric for [application sync duration time](https://github.com/argoproj/argo-cd/issues/11675).

argocd/datadog_checks/argocd/metrics.py

@@ -44,6 +44,7 @@
     'argocd_app_info': 'app.info',
     'argocd_app_reconcile': 'app.reconcile',
     'argocd_app_sync': 'app.sync',
+    'argocd_app_sync_duration_seconds': 'app.sync.duration.seconds',
     'argocd_app_labels': 'app.labels',
     'argocd_cluster_api_resource_objects': 'cluster.api.resource_objects',
     'argocd_cluster_api_resources': 'cluster.api.resources',

argocd/metadata.csv

@@ -49,6 +49,7 @@ argocd.app_controller.app.reconcile.bucket,count,,,,Application reconciliation p
 argocd.app_controller.app.reconcile.count,count,,,,The count aggregation of the application reconciliation performance histogram,0,argocd,app_controller app reconcile count,,
 argocd.app_controller.app.reconcile.sum,count,,,,The sum aggregation of the application reconciliation performance histogram,0,argocd,app_controller app reconcile sum,,
 argocd.app_controller.app.sync.count,count,,,,The total number of application syncs,0,argocd,app_controller app sync,,
+argocd.app_controller.app.sync.duration.seconds.count,count,,second,,Application sync performance in seconds,0,argocd,app_controller app sync duration seconds,,
 argocd.app_controller.cluster.api.resource_objects,gauge,,object,,The number of Kubernetes resource objects in the cache,0,argocd,app_controller cluster api resource_objects,,
 argocd.app_controller.cluster.api.resources,gauge,,resource,,The number of monitored kubernetes API resources.,0,argocd,app_controller cluster api resources,,
 argocd.app_controller.cluster.cache.age.seconds,gauge,,second,,The age of the cluster cache in seconds,0,argocd,app_controller cluster cache age seconds,,

argocd/tests/common.py

@@ -85,6 +85,7 @@
     'redis.request.count',
     'app.k8s.request.count',
     'app.sync.count',
+    'app.sync.duration.seconds.count',
     'cluster.events.count',
     'kubectl.exec.count',
     'workqueue.adds.count',
@@ -208,6 +209,7 @@
     'argocd.app_controller.app.sync.count',
     'argocd.app_controller.cluster.events.count',
     'argocd.app_controller.kubectl.exec.count',
+    'argocd.app_controller.app.sync.duration.seconds.count',
     'argocd.app_controller.app.info',
     'argocd.app_controller.app.reconcile.bucket',
     'argocd.app_controller.app.reconcile.count',

argocd/tests/fixtures/app_controller_metrics.txt

@@ -415,4 +415,8 @@ workqueue_work_duration_seconds_count{name="project_reconciliation_queue"} 6
 argocd_cluster_connection_status{name="foo"} 0
 argocd_cluster_connection_status{name="bar"} 1
 argocd_cluster_connection_status{name="baz"} 2
-argocd_cluster_connection_status{name="faz"} 10
+argocd_cluster_connection_status{name="faz"} 10
+# HELP argocd_app_sync_duration_seconds_total Application sync performance in seconds total.
+# TYPE argocd_app_sync_duration_seconds_total counter
+argocd_app_sync_duration_seconds_total{dest_server="https://kubernetes.default.svc",name="application-bootstrap",namespace="argocd",phase="Succeeded",project="infrastructure"} 1
+argocd_app_sync_duration_seconds_total{dest_server="https://kubernetes.default.svc",name="superhot",namespace="argocd",phase="Failed",project="main"} 1