[SNMP] Fix datadog.snmp.check_duration metric not in tests (DataDog#20867)

* Fix datadog.snmp.check_duration metric

* Add datadog.snmp.check_duration in metrics to skip for Python integration

* Remove useless

* Add quotes?

* Fix space

Author: Pierre-L42

snmp/metadata.csv

@@ -1,6 +1,7 @@
 metric_name,metric_type,interval,unit_name,per_unit_name,description,orientation,integration,short_name,curated_metric
 datadog.snmp.check_duration,gauge,,second,,"The duration of a check run in seconds. The time needed for the integration check to run once on a device, including time to collect snmp data from a device, processing and submitting metrics/service checks/etc.",0,snmp,,
 datadog.snmp.check_interval,count,,second,,The interval between check runs in seconds. The time delta between end of current check run and end of last check run,0,snmp,,
+datadog.snmp.requests,gauge,,,,"The number of SNMP requests sent during a check run.",0,snmp,,
 datadog.snmp.submitted_metrics,gauge,,,,The number of SNMP metrics submitted metrics for a check run (does not include service checks and telemetry metrics).,0,snmp,,
 datadog.snmp_traps.forwarded,count,,packet,,The number of SNMP Traps forwarded.,0,snmp,,
 datadog.snmp_traps.incorrect_format,count,,packet,,The number of SNMP Traps dropped because of an incorrect format tagged by error.,0,snmp,,

snmp/tests/common.py

@@ -301,6 +301,11 @@ def assert_common_check_run_metrics(aggregator, tags=None, is_e2e=False, loader=
     aggregator.assert_metric('datadog.snmp.check_duration', metric_type=aggregator.GAUGE, tags=tags)
     aggregator.assert_metric('datadog.snmp.check_interval', metric_type=monotonic_type, tags=tags)
     aggregator.assert_metric('datadog.snmp.submitted_metrics', metric_type=aggregator.GAUGE, tags=tags)
+    if loader == 'core':
+        # request_type tag can be get, getbulk, or getnext
+        aggregator.assert_metric_has_tag_prefix('datadog.snmp.requests', tag_prefix='request_type:get')
+        for tag in tags:
+            aggregator.assert_metric_has_tag('datadog.snmp.requests', tag)
 
 
 def assert_common_device_metrics(

snmp/tests/test_e2e_core_vs_python.py

@@ -26,6 +26,7 @@
 # Profiles may contain symbols declared twice with different names and the same OID
 # Python check does handle one single metric name per OID symbol
 SKIPPED_CORE_ONLY_METRICS = [
+    'datadog.snmp.requests',
     'snmp.memory.total',
     'snmp.memory.used',
     'snmp.memory.free',