MySQL version compatibility check: move get_check_logger() to except block (DataDog#20833)

Author: Yoone

mysql/changelog.d/20833.fixed

@@ -0,0 +1 @@
+Moved logger instantiation in MySQL version compatibility check to the except block to only perform the costly call to `get_check_logger()` when outputting the warning log.

mysql/datadog_checks/mysql/version_utils.py

@@ -51,13 +51,12 @@ class MySQLVersion(namedtuple('MySQLVersion', ['version', 'flavor', 'build'])):
     def version_compatible(self, compat_version):
         # some patch version numbers contain letters (e.g. 5.0.51a)
         # so let's be careful when we compute the version number
-        log = get_check_logger()
         try:
             mysql_version = self.version.split('.')
         except Exception as e:
-            log.warning("Cannot compute mysql version, assuming it's older.: %s", e)
+            log = get_check_logger()
+            log.warning("Cannot compute MySQL version, assuming it's older: %s", e)
             return False
-        log.debug("MySQL version %s", mysql_version)
 
         patchlevel = int(re.match(r"([0-9]+)", mysql_version[2]).group(1))
         version = (int(mysql_version[0]), int(mysql_version[1]), patchlevel)

mysql/tests/test_unit.py

@@ -139,6 +139,8 @@ def cursor(self):
         assert v.version == '5.5.12'
         assert v.flavor == 'MySQL'
         assert v.build == 'log'
+        assert v.version_compatible(compat_version=(5, 4, 3))
+        assert not v.version_compatible(compat_version=(8, 0, 43))
 
 
 @pytest.mark.parametrize(