Skip to content

Commit 9d36bc6

Browse files
authored
Rename mem_pool_index tag to mem in cisco-firepower-asa profile (DataDog#24582)
Aligns with other profiles (e.g. cisco-nexus) that tag CISCO-ENHANCED-MEMPOOL-MIB memory metrics with mem instead of mem_pool_index.
1 parent 65e6ee8 commit 9d36bc6

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

snmp/datadog_checks/snmp/data/default_profiles/cisco-firepower-asa.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ metrics:
5252
symbol:
5353
OID: 1.3.6.1.4.1.9.9.221.1.1.1.1.3
5454
name: cempMemPoolName
55-
- tag: mem_pool_index
55+
- tag: mem
5656
index: 1
5757
- MIB: CISCO-REMOTE-ACCESS-MONITOR-MIB
5858
symbol:

snmp/tests/test_e2e_core_profiles/test_profile_cisco_firepower_asa.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ def test_e2e_profile_cisco_firepower_asa(dd_agent_check):
4949
aggregator.assert_metric('snmp.crasNumSetupFailInsufResources', metric_type=aggregator.COUNT, tags=common_tags)
5050
aggregator.assert_metric('snmp.crasNumUsers', metric_type=aggregator.GAUGE, tags=common_tags)
5151
mem_tag_rows = [
52-
['mem_pool_index:1', 'mem_pool_name:System memory'],
52+
['mem:1', 'mem_pool_name:System memory'],
5353
]
5454
for tag_row in mem_tag_rows:
5555
aggregator.assert_metric('snmp.memory.free', metric_type=aggregator.GAUGE, tags=common_tags + tag_row)

0 commit comments

Comments
 (0)