Add New External DNS Metrics: controller.consecutive.soft.errors & controller.last_reconcile (DataDog#23671)

* Add metrics external_dns_controller_consecutive_soft_errors & external_dns_controller_last_reconcile_timestamp_seconds

* Updating naming of controller.last_reconcile

* Add changelog

* Sorting metric names

Author: ddog-nasirthomas

external_dns/changelog.d/23671.added

@@ -0,0 +1 @@
+Added metrics external_dns.controller.last_reconcile & external_dns.controller.consecutive.soft.errors

external_dns/datadog_checks/external_dns/metrics.py

@@ -9,4 +9,6 @@
     'source_errors_total': 'source.errors.total',
     'registry_errors_total': 'registry.errors.total',
     'external_dns_controller_last_sync_timestamp_seconds': 'controller.last_sync',
+    'external_dns_controller_consecutive_soft_errors': 'controller.consecutive.soft.errors',
+    'external_dns_controller_last_reconcile_timestamp_seconds': 'controller.last_reconcile',
 }

external_dns/metadata.csv

@@ -1,6 +1,8 @@
-metric_name,metric_type,interval,unit_name,per_unit_name,description,orientation,integration,short_name,curated_metric
-external_dns.controller.last_sync,gauge,,second,,Timestamp of last successful sync with the DNS provider,0,external_dns,controller last sync timestamp,
-external_dns.registry.endpoints.total,gauge,,resource,,Number of registry endpoints,0,external_dns,registry endpoints,
-external_dns.registry.errors.total,gauge,,error,,Number of registry errors,-1,external_dns,registry errors,
-external_dns.source.endpoints.total,gauge,,resource,,Number of source endpoints,0,external_dns,source endpoints,
-external_dns.source.errors.total,gauge,,error,,Number of source errors,-1,external_dns,source errors,
+metric_name,metric_type,interval,unit_name,per_unit_name,description,orientation,integration,short_name,curated_metric,sample_tags
+external_dns.controller.consecutive.soft.errors,gauge,,error,,Number of consecutive soft errors in reconciliation loop,-1,external_dns,controller consecutive soft errors,,
+external_dns.controller.last_reconcile,gauge,,second,,Timestamp of last reconcile attempt,0,external_dns,controller last reconcile timestamp,,
+external_dns.controller.last_sync,gauge,,second,,Timestamp of last successful sync with the DNS provider,0,external_dns,controller last sync timestamp,,
+external_dns.registry.endpoints.total,gauge,,resource,,Number of registry endpoints,0,external_dns,registry endpoints,,
+external_dns.registry.errors.total,gauge,,error,,Number of registry errors,-1,external_dns,registry errors,,
+external_dns.source.endpoints.total,gauge,,resource,,Number of source endpoints,0,external_dns,source endpoints,,
+external_dns.source.errors.total,gauge,,error,,Number of source errors,-1,external_dns,source errors,,

external_dns/tests/fixtures/metrics.txt

@@ -12,4 +12,10 @@ registry_errors_total 0
 source_errors_total 0
 # HELP external_dns_controller_last_sync_timestamp_seconds Timestamp of last successful sync with the DNS provider
 # TYPE external_dns_controller_last_sync_timestamp_seconds gauge
-external_dns_controller_last_sync_timestamp_seconds 1.6343090342347014e+09
+external_dns_controller_last_sync_timestamp_seconds 1.6343090342347014e+09
+# HELP external_dns_controller_consecutive_soft_errors Number of consecutive soft errors in reconciliation loop
+# TYPE external_dns_controller_consecutive_soft_errors gauge
+external_dns_controller_consecutive_soft_errors 0
+# HELP external_dns_controller_last_reconcile_timestamp_seconds Timestamp of last reconcile attempt
+# TYPE external_dns_controller_last_reconcile_timestamp_seconds gauge
+external_dns_controller_last_reconcile_timestamp_seconds 1.715520123e+09