Skip to content

Commit ea18f7f

Browse files
authored
Update the list of supported ClickHouse versions to the latest and relevant metrics (DataDog#21294)
* added system_metrics generator and generated queries * updated default hatch env matrix, added keeper repo * update docker compose files, switched from zookeeper to clickhouse-keeper * updated base conftest for new docker compose * added generator for system events * updated generator, added tests template * added generated data * updated metadata.csv * updated tests * added async metrics parsing * added support of plain and json logs by default * fixed linters * exported new dashboard * added 25.8 and removed 25.5 versions metrics * fixed max desc length for metadata file * added metrics based on system.errors * added metrics stat counter * added system errors check to the agent and fixed e2e * explicit query match mapping * added explicit agent check before the next assert * switch system.errors metrics type to monotonic_gauge and extended metadata.csv descriptions with that info * added changelog entry * updated conf.yaml.example file * increased conditions waiting time on the env startup * split compose files for mounted logs testing and the regular run * fixed metrics_metadata * fixed UNKNOWN_IDENTIFIER metrics name * updated conf.example with new ddev * fixed license-headers * small fixes on dashboard panels * update tests with brand new CH client * linter fix in conftest * removed unfinished test * template typo fixes + renamed metrics prefixes and the package name * removed 25.6 and 25.7 versions * simplified docker setup to 1 CH and 1 Keeper nodes * updated docker setup for legacy CH versions * renamed hatch generator script * rolled back old metrics + added version specific ones * fix format * CI sync * added changelog file * fixed license-headers validator * renamed changelog file * renamed metrics on the dashboard * fixed some leftovers after merge * updated flush_interval_milliseconds for newer CH versions for DBM integration tests * fixed DBM tests on supported CH versions * fixed formatter * updated license-headers * returned previous manifest metric-check name * removed all quantiles * removed `ddsource` assertion from the tests * return ddsource back to fqt_events as it was before * added cache for query manager * added TLS setting after merge conflicts * fixed dbm_integration tests after the merge * added 23.2 and 23.8 to the legacy versions * onboarded new config settings * fixed LogTrace event metric * introduced generic errors.raised metric for all the errors * set version gating for system errors to 21.3 to have remote column * added test for system errors query, fixed dbm query check * fixed linter
1 parent 667cd46 commit ea18f7f

58 files changed

Lines changed: 14159 additions & 839 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/test-all.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -736,6 +736,7 @@ jobs:
736736
- py3.13-23.8
737737
- py3.13-24.8
738738
- py3.13-25.3
739+
- py3.13-25.8
739740
fail-fast: false
740741
j4131274:
741742
uses: ./.github/workflows/test-target.yml

clickhouse/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ See [service_checks.json][9] for a list of service checks provided by this integ
106106
Need help? Contact [Datadog support][10].
107107

108108

109-
[1]: https://clickhouse.yandex
109+
[1]: https://clickhouse.com/
110110
[2]: https://docs.datadoghq.com/agent/kubernetes/integrations/
111111
[3]: /account/settings/agent/latest
112112
[4]: https://github.com/DataDog/integrations-core/blob/master/clickhouse/datadog_checks/clickhouse/data/conf.yaml.example

clickhouse/assets/configuration/spec.yaml

Lines changed: 40 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,16 @@ files:
120120
value:
121121
type: boolean
122122
example: false
123+
- name: use_legacy_queries
124+
description: Enable the legacy query set for collecting metrics. Set to `false` to disable.
125+
value:
126+
type: boolean
127+
example: true
128+
- name: use_advanced_queries
129+
description: Enable the advanced query set for collecting metrics. Set to `false` to disable.
130+
value:
131+
type: boolean
132+
example: true
123133
- name: query_samples
124134
description: Configure collection of database samples snapshots from system.processes
125135
options:
@@ -405,16 +415,42 @@ files:
405415
- template: logs
406416
example:
407417
- source: clickhouse
418+
service: clickhouse
419+
type: file
420+
path: /var/log/clickhouse-server/clickhouse-server.log
421+
tags:
422+
- format:plain
423+
log_processing_rules:
424+
- type: multi_line
425+
name: new_log_start_with_date
426+
pattern: '\d{4}\.\d{2}\.\d{2}'
427+
- source: clickhouse
428+
service: clickhouse
429+
type: file
430+
path: /var/log/clickhouse-server/clickhouse-server.err.log
431+
tags:
432+
- format:plain
433+
log_processing_rules:
434+
- type: multi_line
435+
name: new_log_start_with_date
436+
pattern: '\d{4}\.\d{2}\.\d{2}'
437+
- source: clickhouse
438+
service: clickhouse
408439
type: file
409440
path: /var/log/clickhouse-server/clickhouse-server.log
441+
tags:
442+
- format:json
410443
log_processing_rules:
411444
- type: multi_line
412-
name: log_start_with_date
413-
pattern: \d{4}\.\d{2}\.\d{2}
445+
name: new_log_start_with_json
446+
pattern: '\{'
414447
- source: clickhouse
448+
service: clickhouse
415449
type: file
416450
path: /var/log/clickhouse-server/clickhouse-server.err.log
451+
tags:
452+
- format:json
417453
log_processing_rules:
418454
- type: multi_line
419-
name: log_start_with_date
420-
pattern: \d{4}\.\d{2}\.\d{2}
455+
name: new_log_start_with_json
456+
pattern: '\{'

0 commit comments

Comments
 (0)