Clarify the qa-label check refers to the Agent release cycle (DataDog#23784)

* Spell out that the qa-label check refers to the Agent release cycle

* Add changelog entry

* Use the fixed changelog type for a zero-impact wording change

* Inline the long error string so ruff 0.11.10 stops complaining

Author: AAraKKe

ddev/changelog.d/23784.fixed

@@ -0,0 +1 @@
+Reword the `qa-label` validation messages to make explicit that the check refers to the Datadog Agent release cycle.

ddev/src/ddev/cli/validate/all/orchestrator.py

@@ -105,7 +105,7 @@ class ValidationConfig:
         description="Validate Python package metadata and naming",
     ),
     "qa-label": ValidationConfig(
-        description="Validate the pull request declares a QA decision label",
+        description="Validate the pull request declares whether it needs QA for the next Agent release",
         repo_wide=True,
     ),
     "readmes": ValidationConfig(

ddev/src/ddev/cli/validate/qa_label.py

@@ -19,10 +19,12 @@
 REQUIRED_LABELS: frozenset[str] = frozenset({'qa/skip-qa', 'qa/required'})
 
 HELP_MESSAGE = (
-    "Every pull request must declare its QA expectation by setting exactly one of:\n"
-    "  - 'qa/required'  if this PR ships changes that need to be validated during QA.\n"
-    "  - 'qa/skip-qa'   if this PR does not need QA validation (e.g., docs, tests, "
-    "developer tooling, or no agent-impacting changes).\n"
+    "Every pull request must declare whether its changes require QA validation as part of "
+    "the next Datadog Agent release by setting exactly one of:\n"
+    "  - 'qa/required'  if this PR ships Agent-impacting changes that must be validated "
+    "during the QA phase of the next Agent release.\n"
+    "  - 'qa/skip-qa'   if this PR has no impact on the Agent release (e.g., docs, tests, "
+    "developer tooling, or changes that don't ship with the Agent).\n"
 )
 
 
@@ -34,7 +36,7 @@ def _is_fork_pr(app: Application, event: PullRequestEvent) -> bool:
     return head_repo != base_repo
 
 
-@click.command(short_help='Validate the QA decision label on the current pull request')
+@click.command(short_help='Validate the Agent-release QA decision label on the current pull request')
 @click.pass_obj
 def qa_label(app: Application):
     """Fail unless the current pull request has exactly one QA decision label.
@@ -72,13 +74,13 @@ def qa_label(app: Application):
     qa_labels = sorted(set(labels) & REQUIRED_LABELS)
 
     if len(qa_labels) == 1:
-        app.display_success(f'QA label set: {qa_labels[0]}')
+        app.display_success(f'Agent-release QA label set: {qa_labels[0]}')
         return
 
     if not qa_labels:
-        app.display_error(f'No QA decision label set on PR #{pr_number}.')
+        app.display_error(f'PR #{pr_number} is missing an Agent-release QA decision label.')
     else:
-        app.display_error(f'PR #{pr_number} has more than one QA decision label: {", ".join(qa_labels)}.')
+        app.display_error(f'PR #{pr_number} has more than one Agent-release QA decision label: {", ".join(qa_labels)}.')
 
     app.display_info(HELP_MESSAGE)
     app.abort()

ddev/tests/cli/validate/test_qa_label.py

@@ -50,7 +50,7 @@ def test_passes_with_exactly_one_qa_label(ddev, pr_context, mocker, label):
     result = ddev('validate', 'qa-label')
 
     assert result.exit_code == 0, result.output
-    assert 'QA label set' in result.output
+    assert 'Agent-release QA label set' in result.output
 
 
 def test_fails_when_no_qa_label(ddev, pr_context, mocker):
@@ -59,7 +59,7 @@ def test_fails_when_no_qa_label(ddev, pr_context, mocker):
     result = ddev('validate', 'qa-label')
 
     assert result.exit_code == 1, result.output
-    assert 'No QA decision label set' in result.output
+    assert 'missing an Agent-release QA decision label' in result.output
     assert 'qa/required' in result.output
     assert 'qa/skip-qa' in result.output
 
@@ -70,7 +70,7 @@ def test_fails_when_both_qa_labels(ddev, pr_context, mocker):
     result = ddev('validate', 'qa-label')
 
     assert result.exit_code == 1, result.output
-    assert 'more than one QA decision label' in result.output
+    assert 'more than one Agent-release QA decision label' in result.output
 
 
 def test_skips_outside_pull_request_context(ddev, monkeypatch, mocker):