[pull] master from DataDog:master#29
Merged
Merged
Conversation
This removes a special case where `pymqi` was depended on by all target platforms (including macOS on x86_64/AMD64) *except macOS on AArch64/ARM64*. There doesn't seem to be a compelling reason for keeping such an ad hoc exclusion since `pymqi` 1.12.11 basically consists in an installer that extracts a source tarball (https://pypi.org/project/pymqi/#files) and compiles it for the _effective_ platform, in place. In other words, what works for `macosx_10_12_x86_64` should also work for `macosx_11_0_arm64`. Moreover, `pymqi` is declared as an **optional** project dependency for both "IBM ACE" and "IBM MQ", which already offers some leverage since the dependency is _not installed unless explicitly qualified_: - https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#optional-dependencies - https://pydevtools.com/handbook/explanation/what-are-optional-dependencies-and-dependency-groups/#optional-dependencies-end-user-features Should unforeseen consequences happen despite above cautions, then further actions may be considered (alternatively to a trivial rollback): 1. either drop the dependency at all for macOS where not needed (that is on all macOS architectures), 2. and/or bump IBM MQ deliverables to a version that better accomodates the AArch64/ARM64 architecture on macOS: #20645.
* Fail config validation if templates are missing. Along the way refactor how we search for the templates * changelog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )