[pull] master from DataDog:master#479
Merged
Merged
Conversation
* Set display_priority in rabbitmq spec.yaml based on field usage * Set display_priority on actual config fields, not group headers * Remove display_priority from section group containers in rabbitmq spec.yaml
…3308) * Add descriptions to validations and improve PR comment formatting - Add a description field to ValidationConfig shown in summary tables - Collapse the validation table in PR comments: all-pass wraps the entire table in a <details> block; partial failures show only failures up front with passed validations collapsed - Keep the GitHub Actions step summary as a full flat table - Remove redundant "View full run" link from PR comments * Keep run URL in PR comment, only omit from step summary * Add changelog entry * Address review feedback: extract _build_preamble helper, add missing test coverage, minor cleanups * Rename _post_pr_comment to _publish_report, single-pass partition of results, use extend over repeated appends * Unify section builders into a single _build_report_section with collapsed flag * Fix changelog entry number * Warn about incomplete validations in PR comment and step summary * Use descriptive variable names in results loop * Make expected_count a required positional parameter * Show names of incomplete validations instead of just the count * Lint formatting * Fix Windows test failure: read summary file with utf-8 encoding
* Switch replica_sync_state to use per-replica DMV The previous query used sys.dm_hadr_database_replica_states which returns one row per database per replica, but lacked a database_name tag. This caused metric collisions for AGs with multiple databases. Switch to sys.dm_hadr_availability_replica_states which returns one row per replica, matching the metric's intent. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Apply ruff formatting changes Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * changelog update * changelog update Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Keep synchronization_state_desc and synchronization_state tags for backward compatibility Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Remove synchronization_health_desc tag, keep original tag names Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Update changelog to reflect preserved tag names Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Alias synchronization_health columns in SQL query for clarity Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Alias synchronization_health columns in SQL query for clarity Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Fix changelog wording Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * Drop synchronization_state tag (was not present before) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Adding query errors for ClickHouse * Add integration tests * Updating integration test with more detailed assertion * Update clickhouse/datadog_checks/clickhouse/data/conf.yaml.example Co-authored-by: Eric Weaver <eweaver755@gmail.com> * Regenerating files * Fix instance.py formatting to match CI ddev model generator output Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Exception handling * Fixing linting issues * Updating spec with regenerated config --------- Co-authored-by: Eric Weaver <eweaver755@gmail.com> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )