[pull] master from DataDog:master#48
Merged
Merged
Conversation
* Handle dict access better * Use `caplog` fixture to test logging * Update IP extraction logic * Add test for malformed IP in param name * Remove useless import * Add changelog * Update lustre/changelog.d/20727.fixed Co-authored-by: NouemanKHAL <noueman.khalikine@datadoghq.com> * Apply suggestions from code review Co-authored-by: NouemanKHAL <noueman.khalikine@datadoghq.com> * Improve logging as suggested in code review * Add debug log for non 0 returncode * Assert at least one filesystem was found in discovery * Separate log tests * Improve handle_ip function logic --------- Co-authored-by: NouemanKHAL <noueman.khalikine@datadoghq.com>
* added new process level metrics to the metadata.csv * fixed sorting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )